From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: datastore/Content: add forget button for groups
Date: Fri, 14 May 2021 16:36:03 +0200 [thread overview]
Message-ID: <20210514143603.6713-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210514143603.6713-1-d.csapak@proxmox.com>
since we can remove whole groups via api now
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Content.js | 34 +++++++++++++++++++++++++---------
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 1394b2ea..67ebbdac 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -382,10 +382,30 @@ Ext.define('PBS.DataStoreContent', {
let data = rec.data;
if (!view.datastore) return;
+ let params;
+ let message;
+ let url;
+ if (rec.parentNode.id !== 'root') {
+ message = Ext.String.format(gettext('Are you sure you want to remove snapshot {0}'), `'${data.text}'`);
+ url = `/admin/datastore/${view.datastore}/snapshots`;
+ params = {
+ "backup-type": data["backup-type"],
+ "backup-id": data["backup-id"],
+ "backup-time": (data['backup-time'].getTime()/1000).toFixed(0),
+ };
+ } else {
+ message = Ext.String.format(gettext('Are you sure you want to remove group {0}'), `'${data.text}'`);
+ url = `/admin/datastore/${view.datastore}/groups`;
+ params = {
+ "backup-type": data.backup_type,
+ "backup-id": data.backup_id,
+ };
+ }
+
Ext.Msg.show({
title: gettext('Confirm'),
icon: Ext.Msg.WARNING,
- message: Ext.String.format(gettext('Are you sure you want to remove snapshot {0}'), `'${data.text}'`),
+ message,
buttons: Ext.Msg.YESNO,
defaultFocus: 'no',
callback: function(btn) {
@@ -394,12 +414,8 @@ Ext.define('PBS.DataStoreContent', {
}
Proxmox.Utils.API2Request({
- params: {
- "backup-type": data["backup-type"],
- "backup-id": data["backup-id"],
- "backup-time": (data['backup-time'].getTime()/1000).toFixed(0),
- },
- url: `/admin/datastore/${view.datastore}/snapshots`,
+ url,
+ params,
method: 'DELETE',
waitMsgTarget: view,
failure: function(response, opts) {
@@ -617,8 +633,8 @@ Ext.define('PBS.DataStoreContent', {
{
handler: 'onForget',
getTip: (v, m, rec) => Ext.String.format(gettext("Permanently forget snapshot '{0}'"), v),
- getClass: (v, m, rec) => !rec.data.leaf && rec.parentNode.id !== 'root' ? 'fa critical fa-trash-o' : 'pmx-hidden',
- isDisabled: (v, r, c, i, rec) => rec.data.leaf || rec.parentNode.id === 'root',
+ getClass: (v, m, rec) => !rec.data.leaf ? 'fa critical fa-trash-o' : 'pmx-hidden',
+ isDisabled: (v, r, c, i, rec) => !!rec.data.leaf,
},
{
handler: 'downloadFile',
--
2.20.1
next prev parent reply other threads:[~2021-05-14 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 14:36 [pbs-devel] [PATCH proxmox-backup 1/2] api2/admin/datastore: add delete " Dominik Csapak
2021-05-14 14:36 ` Dominik Csapak [this message]
2021-05-17 6:46 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514143603.6713-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox