public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] ui: window/SyncJobEdit: disable autoSelect for remote datastore
@ 2021-05-10 11:22 Dominik Csapak
  2021-05-10 14:57 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-05-10 11:22 UTC (permalink / raw)
  To: pbs-devel

when changin the remote, there is a high chance that there are different
datastores, and if a user does not pay attention, now the first store
of the new remote is selected, instead of the one with the same name

disable autoSelect and let the user manually select a remote datastore

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/window/SyncJobEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index af4d2fa9..47e65ae3 100644
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -182,6 +182,7 @@ Ext.define('PBS.window.SyncJobEdit', {
 		fieldLabel: gettext('Source Datastore'),
 		xtype: 'pbsRemoteStoreSelector',
 		allowBlank: false,
+		autoSelect: false,
 		name: 'remote-store',
 		disabled: true,
 	    },
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] ui: window/SyncJobEdit: disable autoSelect for remote datastore
  2021-05-10 11:22 [pbs-devel] [PATCH proxmox-backup] ui: window/SyncJobEdit: disable autoSelect for remote datastore Dominik Csapak
@ 2021-05-10 14:57 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-05-10 14:57 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Dominik Csapak

On 10.05.21 13:22, Dominik Csapak wrote:
> when changin the remote, there is a high chance that there are different
> datastores, and if a user does not pay attention, now the first store
> of the new remote is selected, instead of the one with the same name
> 
> disable autoSelect and let the user manually select a remote datastore
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/window/SyncJobEdit.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-10 14:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 11:22 [pbs-devel] [PATCH proxmox-backup] ui: window/SyncJobEdit: disable autoSelect for remote datastore Dominik Csapak
2021-05-10 14:57 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal