public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: tape: rename 'Datastore' to 'Target Datastore'
Date: Mon, 10 May 2021 13:19:46 +0200	[thread overview]
Message-ID: <20210510111946.7087-1-d.csapak@proxmox.com> (raw)

we have 2 modi in that window:
* backup has multiple datastores
* backup has single datastore

In the first case we show a 'mapping' grid so that
the user can only restore a part. Here a user sees all source
Datastores and can select a target for each one.

In the second case we only have a single 'Datastore' selector, but
we do not show the source. Because of this, the naming is slightly ambiguous
(is it the 'Source' or the 'Target' ?), so rename it to 'Target Datastore'.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/window/TapeRestore.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index 85011cba..edb21668 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -85,7 +85,7 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
 		},
 		{
 		    xtype: 'pbsDataStoreSelector',
-		    fieldLabel: gettext('Datastore'),
+		    fieldLabel: gettext('Target Datastore'),
 		    reference: 'defaultDatastore',
 		    name: 'store',
 		    listeners: {
@@ -127,7 +127,7 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
 	if (!datastores || datastores.length <= 1) {
 	    label.setVisible(false);
 	    grid.setVisible(false);
-	    defaultField.setFieldLabel(gettext('Datastore'));
+	    defaultField.setFieldLabel(gettext('Target Datastore'));
 	    defaultField.setAllowBlank(false);
 	    defaultField.setEmptyText("");
 	    return;
-- 
2.20.1





             reply	other threads:[~2021-05-10 11:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 11:19 Dominik Csapak [this message]
2021-05-10 14:57 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210510111946.7087-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal