public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] proxmox_restore_daemon: mount ntfs with 'utf8' option
@ 2021-05-05  8:46 Dominik Csapak
  2021-05-05  9:09 ` [pbs-devel] applied: " Dietmar Maurer
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-05-05  8:46 UTC (permalink / raw)
  To: pbs-devel

otherwise, the kernel driver exposes file names as iso 8859-1,
but we want to have them as utf8.

This mapping should always work, since UTF16 can be cleanly converted
to UTF8.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/bin/proxmox_restore_daemon/disk.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/bin/proxmox_restore_daemon/disk.rs b/src/bin/proxmox_restore_daemon/disk.rs
index 47c718f8..b58a84ff 100644
--- a/src/bin/proxmox_restore_daemon/disk.rs
+++ b/src/bin/proxmox_restore_daemon/disk.rs
@@ -31,6 +31,8 @@ lazy_static! {
         // whatever the user is trying to restore is not using anything older...
         m.insert("ufs", "ufstype=ufs2");
 
+        m.insert("ntfs", "utf8");
+
         m
     };
 }
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] proxmox_restore_daemon: mount ntfs with 'utf8' option
  2021-05-05  8:46 [pbs-devel] [PATCH proxmox-backup] proxmox_restore_daemon: mount ntfs with 'utf8' option Dominik Csapak
@ 2021-05-05  9:09 ` Dietmar Maurer
  0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2021-05-05  9:09 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Dominik Csapak

applied

On 5/5/21 10:46 AM, Dominik Csapak wrote:
> otherwise, the kernel driver exposes file names as iso 8859-1,
> but we want to have them as utf8.
>
> This mapping should always work, since UTF16 can be cleanly converted
> to UTF8.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   src/bin/proxmox_restore_daemon/disk.rs | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/bin/proxmox_restore_daemon/disk.rs b/src/bin/proxmox_restore_daemon/disk.rs
> index 47c718f8..b58a84ff 100644
> --- a/src/bin/proxmox_restore_daemon/disk.rs
> +++ b/src/bin/proxmox_restore_daemon/disk.rs
> @@ -31,6 +31,8 @@ lazy_static! {
>           // whatever the user is trying to restore is not using anything older...
>           m.insert("ufs", "ufstype=ufs2");
>   
> +        m.insert("ntfs", "utf8");
> +
>           m
>       };
>   }




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-05  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05  8:46 [pbs-devel] [PATCH proxmox-backup] proxmox_restore_daemon: mount ntfs with 'utf8' option Dominik Csapak
2021-05-05  9:09 ` [pbs-devel] applied: " Dietmar Maurer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal