* [pbs-devel] [PATCH proxmox-backup] tools/sgutils2: improve error messages
@ 2021-04-26 13:01 Dominik Csapak
0 siblings, 0 replies; only message in thread
From: Dominik Csapak @ 2021-04-26 13:01 UTC (permalink / raw)
To: pbs-devel
include the expected and unexpected sizes in the error message,
so that it's easier to debug in case of an error
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/tools/sgutils2.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/tools/sgutils2.rs b/src/tools/sgutils2.rs
index 5273173f..06506896 100644
--- a/src/tools/sgutils2.rs
+++ b/src/tools/sgutils2.rs
@@ -759,18 +759,18 @@ pub fn scsi_mode_sense<F: AsRawFd, P: Endian>(
let head: ModeParameterHeader = unsafe { reader.read_be_value()? };
if (head.mode_data_len as usize + 2) != data.len() {
- bail!("wrong mode_data_len");
+ bail!("wrong mode_data_len: {}, expected {}", head.mode_data_len, data.len() - 2);
}
if disable_block_descriptor && head.block_descriptior_len != 0 {
- bail!("wrong block_descriptior_len");
+ bail!("wrong block_descriptior_len: {}, expected 0", head.block_descriptior_len);
}
let mut block_descriptor: Option<ModeBlockDescriptor> = None;
if !disable_block_descriptor {
if head.block_descriptior_len != 8 {
- bail!("wrong block_descriptior_len");
+ bail!("wrong block_descriptior_len: {}, expected 8", head.block_descriptior_len);
}
block_descriptor = Some(unsafe { reader.read_be_value()? });
--
2.20.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-26 13:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26 13:01 [pbs-devel] [PATCH proxmox-backup] tools/sgutils2: improve error messages Dominik Csapak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox