* [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping
@ 2021-03-29 11:25 Dominik Csapak
2021-03-29 11:25 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeRestore: use correct value check for store & mapping Dominik Csapak
2021-04-08 6:19 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping Dominik Csapak
0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-03-29 11:25 UTC (permalink / raw)
To: pbs-devel
we have to delete the 'mapping' variable in any case since it's not
a valid api parameter
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/window/TapeRestore.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index a9deb745..d33080e4 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -30,8 +30,8 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
if (values.mapping) {
datastores.push(values.mapping);
- delete values.mapping;
}
+ delete values.mapping;
values.store = datastores.join(',');
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeRestore: use correct value check for store & mapping
2021-03-29 11:25 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping Dominik Csapak
@ 2021-03-29 11:25 ` Dominik Csapak
2021-04-08 6:19 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping Dominik Csapak
1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-03-29 11:25 UTC (permalink / raw)
To: pbs-devel
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/window/TapeRestore.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index d33080e4..85011cba 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -23,12 +23,12 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
onGetValues: function(values) {
let me = this;
let datastores = [];
- if (values.store && values.store !== "") {
+ if (values.store.toString() !== "") {
datastores.push(values.store);
delete values.store;
}
- if (values.mapping) {
+ if (values.mapping.toString() !== "") {
datastores.push(values.mapping);
}
delete values.mapping;
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping
2021-03-29 11:25 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping Dominik Csapak
2021-03-29 11:25 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeRestore: use correct value check for store & mapping Dominik Csapak
@ 2021-04-08 6:19 ` Dominik Csapak
1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-04-08 6:19 UTC (permalink / raw)
To: pbs-devel
any comment?
On 3/29/21 1:25 PM, Dominik Csapak wrote:
> we have to delete the 'mapping' variable in any case since it's not
> a valid api parameter
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/window/TapeRestore.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index a9deb745..d33080e4 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -30,8 +30,8 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
>
> if (values.mapping) {
> datastores.push(values.mapping);
> - delete values.mapping;
> }
> + delete values.mapping;
>
> values.store = datastores.join(',');
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-08 6:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 11:25 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping Dominik Csapak
2021-03-29 11:25 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeRestore: use correct value check for store & mapping Dominik Csapak
2021-04-08 6:19 ` [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping Dominik Csapak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox