From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: NavigationTree: do not modify list while iterating
Date: Wed, 10 Mar 2021 10:10:46 +0100 [thread overview]
Message-ID: <20210310091047.16557-1-d.csapak@proxmox.com> (raw)
iterating over a nodeinterfaces children while removing them
will lead to 'child' being undefined
instead collect the children to remove in a separate list
and iterate over them
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/NavigationTree.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/NavigationTree.js b/www/NavigationTree.js
index a9e97567..4bdfbc66 100644
--- a/www/NavigationTree.js
+++ b/www/NavigationTree.js
@@ -188,11 +188,13 @@ Ext.define('PBS.view.main.NavigationTree', {
}
}
+ let toremove = [];
list.eachChild((child) => {
if (!newSet[child.data.path]) {
- list.removeChild(child, true);
+ toremove.push(child);
}
});
+ toremove.forEach((child) => list.removeChild(child, true));
if (view.pathToSelect !== undefined) {
let path = view.pathToSelect;
--
2.20.1
next reply other threads:[~2021-03-10 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:10 Dominik Csapak [this message]
2021-03-10 9:10 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval Dominik Csapak
2021-03-10 11:19 ` Thomas Lamprecht
2021-03-10 11:38 ` Dominik Csapak
2021-03-10 11:47 ` Thomas Lamprecht
2021-03-10 12:32 ` Dominik Csapak
2021-03-10 12:41 ` Thomas Lamprecht
2021-03-10 10:01 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: NavigationTree: do not modify list while iterating Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310091047.16557-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox