From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/3] tape/linux_tape: remove debug prints
Date: Mon, 8 Mar 2021 14:10:50 +0100 [thread overview]
Message-ID: <20210308131051.11767-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210308131051.11767-1-d.csapak@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
maybe we want to have them but behind a 'verbose' parameter for the cli?
src/tape/drive/linux_tape.rs | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/tape/drive/linux_tape.rs b/src/tape/drive/linux_tape.rs
index ad8c5e98..b5cded05 100644
--- a/src/tape/drive/linux_tape.rs
+++ b/src/tape/drive/linux_tape.rs
@@ -444,7 +444,6 @@ impl TapeDriver for LinuxTapeHandle {
fn sync(&mut self) -> Result<(), Error> {
- println!("SYNC/FLUSH TAPE");
// MTWEOF with count 0 => flush
let cmd = mtop { mt_op: MTCmd::MTWEOF, mt_count: 0 };
@@ -654,7 +653,6 @@ impl TapeDriver for LinuxTapeHandle {
/// Write a single EOF mark without flushing buffers
fn tape_write_eof_mark(file: &File) -> Result<(), std::io::Error> {
- println!("WRITE EOF MARK");
let cmd = mtop { mt_op: MTCmd::MTWEOFI, mt_count: 1 };
unsafe {
@@ -759,7 +757,6 @@ impl TapeWrite for TapeWriterHandle<'_> {
}
fn finish(&mut self, incomplete: bool) -> Result<bool, std::io::Error> {
- println!("FINISH TAPE HANDLE");
let leof = self.writer.finish(incomplete)?;
tape_write_eof_mark(self.writer.writer_ref_mut())?;
Ok(leof)
--
2.20.1
next prev parent reply other threads:[~2021-03-08 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 13:10 [pbs-devel] [PATCH proxmox-backup 1/3] tape/backup: add success/error notifications Dominik Csapak
2021-03-08 13:10 ` Dominik Csapak [this message]
2021-03-08 13:10 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: tape/window/Tape{Backup, Restore}: allow empty notify user field Dominik Csapak
2021-03-08 13:30 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] tape/backup: add success/error notifications Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308131051.11767-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox