[pbs-devel] [PATCH proxmox-backup] Fix 3321: fix interactive restore command explanation

[pbs-devel] [PATCH proxmox-backup] Fix 3321: fix interactive restore command explanation

[Dylan Whyte]

The previous description in the docs was false. The restore command
with the pattern parameter will search the entire backup archive,
regardless of pwd.

Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
---

As a side note, the behaviour in the interactive shell still seems
somewhat broken to me. In the case of this example, if
you were to cd into etc and run the command with the pattern
'**/*.conf', it would still search the entire archive rather than just /etc. Is
this how it should be?

 docs/backup-client.rst | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/docs/backup-client.rst b/docs/backup-client.rst
index 384de958..598fd55d 100644
--- a/docs/backup-client.rst
+++ b/docs/backup-client.rst
@@ -460,16 +460,15 @@ subdirectory and add the corresponding pattern to the list for subsequent restor
 all files in the archive matching the patterns to ``/target/path`` on the local
 host. This will scan the whole archive.
 
-With ``restore /target/path`` you can restore the sub-archive given by the current
-working directory to the local target path ``/target/path`` on your host.
-By additionally passing a glob pattern with ``--pattern <glob>``, the restore is
-further limited to files matching the pattern.
-For example:
+The ``restore`` command can be used to restore all the files contained within
+the backup archive. This is most helpful when paired with the ``--pattern
+<glob>`` option, as it allows you to restore all files matching a specific
+pattern. For example, if you wanted to restore configuration files
+located in ``/etc``, you could do the following:
 
 .. code-block:: console
 
-  pxar:/ > cd /etc/
-  pxar:/etc/ > restore /target/ --pattern **/*.conf
+  pxar:/ > restore target/ --pattern etc/**/*.conf
   ...
 
 The above will scan trough all the directories below ``/etc`` and restore all
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup] Fix 3321: fix interactive restore command explanation

[Dietmar Maurer]

applied, see question below:

> On 03/02/2021 2:50 PM Dylan Whyte <d.whyte@proxmox.com> wrote:
> 
>  
> The previous description in the docs was false. The restore command
> with the pattern parameter will search the entire backup archive,
> regardless of pwd.
> 
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
> 
> As a side note, the behaviour in the interactive shell still seems
> somewhat broken to me. In the case of this example, if
> you were to cd into etc and run the command 

run what command exactly?

> with the pattern
> '**/*.conf', it would still search the entire archive rather than just /etc. Is
> this how it should be?