From: Dylan Whyte <d.whyte@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] Fix 3321: fix interactive restore command explanation
Date: Tue, 2 Mar 2021 14:50:19 +0100 [thread overview]
Message-ID: <20210302135019.14433-1-d.whyte@proxmox.com> (raw)
The previous description in the docs was false. The restore command
with the pattern parameter will search the entire backup archive,
regardless of pwd.
Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
---
As a side note, the behaviour in the interactive shell still seems
somewhat broken to me. In the case of this example, if
you were to cd into etc and run the command with the pattern
'**/*.conf', it would still search the entire archive rather than just /etc. Is
this how it should be?
docs/backup-client.rst | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/docs/backup-client.rst b/docs/backup-client.rst
index 384de958..598fd55d 100644
--- a/docs/backup-client.rst
+++ b/docs/backup-client.rst
@@ -460,16 +460,15 @@ subdirectory and add the corresponding pattern to the list for subsequent restor
all files in the archive matching the patterns to ``/target/path`` on the local
host. This will scan the whole archive.
-With ``restore /target/path`` you can restore the sub-archive given by the current
-working directory to the local target path ``/target/path`` on your host.
-By additionally passing a glob pattern with ``--pattern <glob>``, the restore is
-further limited to files matching the pattern.
-For example:
+The ``restore`` command can be used to restore all the files contained within
+the backup archive. This is most helpful when paired with the ``--pattern
+<glob>`` option, as it allows you to restore all files matching a specific
+pattern. For example, if you wanted to restore configuration files
+located in ``/etc``, you could do the following:
.. code-block:: console
- pxar:/ > cd /etc/
- pxar:/etc/ > restore /target/ --pattern **/*.conf
+ pxar:/ > restore target/ --pattern etc/**/*.conf
...
The above will scan trough all the directories below ``/etc`` and restore all
--
2.20.1
next reply other threads:[~2021-03-02 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 13:50 Dylan Whyte [this message]
2021-03-03 8:38 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302135019.14433-1-d.whyte@proxmox.com \
--to=d.whyte@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox