public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/5] ui: tape: refactor renderDriveState to Utils
Date: Tue,  2 Mar 2021 12:19:37 +0100	[thread overview]
Message-ID: <20210302111940.17276-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210302111940.17276-1-d.csapak@proxmox.com>

we will use this later again

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/Utils.js              | 16 ++++++++++++++++
 www/tape/ChangerStatus.js | 18 +-----------------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/www/Utils.js b/www/Utils.js
index c531edbb..778dad24 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -603,6 +603,22 @@ Ext.define('PBS.Utils', {
 	}).show();
     },
 
+    renderDriveState: function(value, md) {
+	if (!value) {
+	    return gettext('Idle');
+	}
+
+	let icon = '<i class="fa fa-spinner fa-pulse fa-fw"></i>';
+
+	if (value.startsWith("UPID")) {
+	    let upid = Proxmox.Utils.parse_task_upid(value);
+	    md.tdCls = "pointer";
+	    return `${icon} ${upid.desc}`;
+	}
+
+	return `${icon} ${value}`;
+    },
+
 });
 
 Ext.define('PBS.Async', {
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 2f9c41f8..42306007 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -463,22 +463,6 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	    return status;
 	},
 
-	renderState: function(value, md, record) {
-	    if (!value) {
-		return gettext('Idle');
-	    }
-
-	    let icon = '<i class="fa fa-spinner fa-pulse fa-fw"></i>';
-
-	    if (value.startsWith("UPID")) {
-		let upid = Proxmox.Utils.parse_task_upid(value);
-		md.tdCls = "pointer";
-		return `${icon} ${upid.desc}`;
-	    }
-
-	    return `${icon} ${value}`;
-	},
-
 	control: {
 	    'grid[reference=drives]': {
 		cellclick: function(table, td, ci, rec, tr, ri, e) {
@@ -683,7 +667,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 				    text: gettext('State'),
 				    dataIndex: 'state',
 				    flex: 3,
-				    renderer: 'renderState',
+				    renderer: PBS.Utils.renderDriveState,
 				},
 				{
 				    text: gettext("Vendor"),
-- 
2.20.1





  reply	other threads:[~2021-03-02 11:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 11:19 [pbs-devel] [PATCH proxmox-backup 1/5] api2/tape/drive: add state to DriveListEntry Dominik Csapak
2021-03-02 11:19 ` Dominik Csapak [this message]
2021-03-02 11:19 ` [pbs-devel] [PATCH proxmox-backup 3/5] ui: tape/DriveStatus: add more status lines Dominik Csapak
2021-03-02 11:19 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: tape/DriveStatus: add state to Info panel Dominik Csapak
2021-03-02 11:19 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: tape/DriveStatus: use the drive state to determine a status-load Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302111940.17276-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal