public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons
@ 2021-03-01 13:13 Dominik Csapak
  2021-03-01 13:13 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: fix eslint warnings Dominik Csapak
  2021-03-01 13:19 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons Dietmar Maurer
  0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-03-01 13:13 UTC (permalink / raw)
  To: pbs-devel

they live now in the drive status panel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/DriveConfig.js | 58 -----------------------------------------
 1 file changed, 58 deletions(-)

diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
index 70b3870d..4845a8bc 100644
--- a/www/tape/DriveConfig.js
+++ b/www/tape/DriveConfig.js
@@ -55,20 +55,6 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
 	    });
 	},
 
-	catalog: function(button, event, record) {
-	    let me = this;
-	    let drive = record.data.name;
-	    PBS.Utils.driveCommand(drive, 'catalog', {
-		waitMsgTarget: me.getView(),
-		method: 'POST',
-		success: function(response) {
-		    Ext.create('Proxmox.window.TaskViewer', {
-			upid: response.result.data,
-		    }).show();
-		},
-	    });
-	},
-
 	readLabel: function(view, rI, cI, button, el, record) {
 	    let me = this;
 	    let drive = record.data.name;
@@ -97,29 +83,6 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
 	    });
 	},
 
-	labelMedia: function(button, event, record) {
-	    let me = this;
-	    let driveid = record.data.name;
-
-	    Ext.create('PBS.TapeManagement.LabelMediaWindow', {
-		driveid,
-	    }).show();
-	},
-
-	ejectMedia: function(button, event, record) {
-	    let me = this;
-	    let driveid = record.data.name;
-	    PBS.Utils.driveCommand(driveid, 'eject-media', {
-		waitMsgTarget: me.getView(),
-		method: 'POST',
-		success: function(response) {
-		    Ext.create('Proxmox.window.TaskProgress', {
-			upid: response.result.data,
-		    }).show();
-		},
-	    });
-	},
-
 	reload: function() {
 	    this.getView().getStore().rstore.load();
 	},
@@ -192,27 +155,6 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
 	    baseurl: '/api2/extjs/config/drive',
 	    callback: 'reload',
 	},
-	'-',
-	{
-	    text: gettext('Label Media'),
-	    xtype: 'proxmoxButton',
-	    handler: 'labelMedia',
-	    iconCls: 'fa fa-barcode',
-	    disabled: true,
-	},
-	{
-	    text: gettext('Eject'),
-	    xtype: 'proxmoxButton',
-	    handler: 'ejectMedia',
-	    disabled: true,
-	},
-	{
-	    text: gettext('Catalog'),
-	    xtype: 'proxmoxButton',
-	    handler: 'catalog',
-	    iconCls: 'fa fa-book',
-	    disabled: true,
-	},
     ],
     columns: [
 	{
-- 
2.20.1





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: fix eslint warnings
  2021-03-01 13:13 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons Dominik Csapak
@ 2021-03-01 13:13 ` Dominik Csapak
  2021-03-01 13:19 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons Dietmar Maurer
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-03-01 13:13 UTC (permalink / raw)
  To: pbs-devel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/DriveConfig.js          | 2 +-
 www/tape/window/TapeBackupJob.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
index 4845a8bc..0dfd2b89 100644
--- a/www/tape/DriveConfig.js
+++ b/www/tape/DriveConfig.js
@@ -187,7 +187,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
 	    dataIndex: 'changer-drivenum',
 	    renderer: function(value, mD, record) {
 		return record.data.changer ? value : '';
-	    }
+	    },
 	},
 	{
 	    text: gettext('Actions'),
diff --git a/www/tape/window/TapeBackupJob.js b/www/tape/window/TapeBackupJob.js
index 7cd3e462..e7f89d69 100644
--- a/www/tape/window/TapeBackupJob.js
+++ b/www/tape/window/TapeBackupJob.js
@@ -33,7 +33,7 @@ Ext.define('PBS.TapeManagement.BackupJobEdit', {
 	    let me = this;
 
 	    if (values['export-media-set'] && !me.up('pbsTapeBackupJobEdit').isCreate) {
-		Proxmox.Utils.assemble_field_data(values, { delete: 'eject-media' });
+		Proxmox.Utils.assemble_field_data(values, { "delete": 'eject-media' });
 	    }
 	    return values;
 	},
-- 
2.20.1





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons
  2021-03-01 13:13 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons Dominik Csapak
  2021-03-01 13:13 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: fix eslint warnings Dominik Csapak
@ 2021-03-01 13:19 ` Dietmar Maurer
  1 sibling, 0 replies; 3+ messages in thread
From: Dietmar Maurer @ 2021-03-01 13:19 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Dominik Csapak

applied both patches




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-01 13:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 13:13 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons Dominik Csapak
2021-03-01 13:13 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: fix eslint warnings Dominik Csapak
2021-03-01 13:19 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/DriveConfig: remove label/catalog/eject buttons Dietmar Maurer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal