From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox/proxmox-backup v5] restore files from pxar sparsely
Date: Tue, 23 Feb 2021 15:08:17 +0100 [thread overview]
Message-ID: <20210223140817.owxt4bau743mptko@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20210217131322.9129-1-d.csapak@proxmox.com>
applied all patches, bumped proxmox crate
On Wed, Feb 17, 2021 at 02:13:19PM +0100, Dominik Csapak wrote:
> to be able to restore containers with big sparse files
>
> ideally we would save hole information directly in the pxar archive
> and not even use zero chunks, so that we can have smaller
> pxar archives, and accurately restore sparse files like they were before
>
> for now, restore all files sparsely
>
> changes from v4:
> * moved proxmox test code into a toplevel testmodule that is behind
> a #[cfg(test)] and adapted the tests
>
> changes from v3:
> * collect subsequent holes, so that we only seek one time per hole
> * add tests for sparse_copy(_async)
> * also return if the last operation was a seek and only truncate then
> * create buffer with explicit 4096 bytes
> * use rustfmt
> * adds a patch to add poll_once to proxmox module (for async testing)
>
> changes from v2:
> * always sparse copy and truncate after
>
> changes from RFC:
> * drop the zero module of proxmox, rust can generate fast code by itself
>
> proxmox:
>
> Dominik Csapak (2):
> proxmox: add test/{io,task} modules
> proxmox: add sparse_copy(_async) to tools::io
>
> proxmox/src/lib.rs | 3 +
> proxmox/src/test/io.rs | 94 ++++++++++++++
> proxmox/src/test/mod.rs | 2 +
> proxmox/src/test/task.rs | 32 +++++
> proxmox/src/tools/io/mod.rs | 243 ++++++++++++++++++++++++++++++++++++
> 5 files changed, 374 insertions(+)
> create mode 100644 proxmox/src/test/io.rs
> create mode 100644 proxmox/src/test/mod.rs
> create mode 100644 proxmox/src/test/task.rs
>
> proxmox-backup:
>
> Dominik Csapak (1):
> pxar/extract: if possible create files sparesly
>
> src/pxar/extract.rs | 43 ++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 36 insertions(+), 7 deletions(-)
>
> --
> 2.20.1
prev parent reply other threads:[~2021-02-23 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 13:13 [pbs-devel] " Dominik Csapak
2021-02-17 13:13 ` [pbs-devel] [PATCH proxmox v5 1/2] proxmox: add test/{io, task} modules Dominik Csapak
2021-02-17 13:13 ` [pbs-devel] [PATCH proxmox v5 2/2] proxmox: add sparse_copy(_async) to tools::io Dominik Csapak
2021-02-17 13:13 ` [pbs-devel] [PATCH proxmox-backup v5 1/1] pxar/extract: if possible create files sparesly Dominik Csapak
2021-02-23 14:08 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223140817.owxt4bau743mptko@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox