* [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields
@ 2021-02-23 8:06 Dominik Csapak
2021-02-23 8:06 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: do not show progressbar for (un)load Dominik Csapak
2021-02-23 8:10 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dietmar Maurer
0 siblings, 2 replies; 4+ messages in thread
From: Dominik Csapak @ 2021-02-23 8:06 UTC (permalink / raw)
To: pbs-devel
the DiffStore only updates the fiels given in the model, so we have to
list all the fields we depend on, else we have incomplete data,
e.g. for rendering
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/ChangerStatus.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index b1a294c4..fcf4d6dd 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -1,6 +1,6 @@
Ext.define('pbs-slot-model', {
extend: 'Ext.data.Model',
- fields: ['entry-id', 'label-text', 'is-labeled', ' model', 'name', 'vendor', 'serial', 'state',
+ fields: ['entry-id', 'label-text', 'is-labeled', ' model', 'name', 'vendor', 'serial', 'state', 'status', 'pool',
{
name: 'is-blocked',
calculate: function(data) {
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: do not show progressbar for (un)load
2021-02-23 8:06 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dominik Csapak
@ 2021-02-23 8:06 ` Dominik Csapak
2021-02-23 8:11 ` [pbs-devel] applied: " Dietmar Maurer
2021-02-23 8:10 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dietmar Maurer
1 sibling, 1 reply; 4+ messages in thread
From: Dominik Csapak @ 2021-02-23 8:06 UTC (permalink / raw)
To: pbs-devel
since we already show the state of the drive in the grid, this is
not necessary
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/ChangerStatus.js | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index fcf4d6dd..8be600d8 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -134,7 +134,6 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
submitText: gettext('OK'),
title: gettext('Load Media into Drive'),
url: `/api2/extjs/tape/drive`,
- showProgress: true,
method: 'POST',
submitUrl: function(url, values) {
let drive = values.drive;
@@ -168,21 +167,15 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
let me = this;
let drive = record.data.name;
try {
- let response = await PBS.Async.api2({
+ await PBS.Async.api2({
method: 'POST',
timeout: 5*60*1000,
url: `/api2/extjs/tape/drive/${encodeURIComponent(drive)}/unload`,
});
-
- Ext.create('Proxmox.window.TaskProgress', {
- autoShow: true,
- upid: response.result.data,
- taskDone: () => me.reload(),
- });
} catch (error) {
Ext.Msg.alert(gettext('Error'), error);
- me.reload();
}
+ me.reload();
},
driveCommand: function(driveid, command, callback, params, method) {
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields
2021-02-23 8:06 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dominik Csapak
2021-02-23 8:06 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: do not show progressbar for (un)load Dominik Csapak
@ 2021-02-23 8:10 ` Dietmar Maurer
1 sibling, 0 replies; 4+ messages in thread
From: Dietmar Maurer @ 2021-02-23 8:10 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-23 8:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 8:06 [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dominik Csapak
2021-02-23 8:06 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: do not show progressbar for (un)load Dominik Csapak
2021-02-23 8:11 ` [pbs-devel] applied: " Dietmar Maurer
2021-02-23 8:10 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: add missing model fields Dietmar Maurer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox