[pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: fix eslint warnings (trailing comma)

[pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: fix eslint warnings (trailing comma)

[Dominik Csapak]

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/BackupJobs.js    | 6 +++---
 www/tape/ChangerStatus.js | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/www/tape/BackupJobs.js b/www/tape/BackupJobs.js
index f8a64694..7c23864f 100644
--- a/www/tape/BackupJobs.js
+++ b/www/tape/BackupJobs.js
@@ -13,7 +13,7 @@ Ext.define('pbs-tape-backup-job-status', {
 		let task = Proxmox.Utils.parse_task_upid(data['last-run-upid']);
 		return endtime - task.starttime;
 	    },
-	}
+	},
     ],
     idProperty: 'id',
     proxy: {
@@ -42,7 +42,7 @@ Ext.define('PBS.config.TapeBackupJobView', {
 
 	init: function(view) {
 	    Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);
-	}
+	},
     },
 
     listeners: {
@@ -143,5 +143,5 @@ Ext.define('PBS.config.TapeBackupJobView', {
 	let me = this;
 
 	me.callParent();
-    }
+    },
 });
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 2e35c55c..5a1c6073 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -422,7 +422,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		    method: 'GET',
 		    params: {
 			"update-status": false,
-		    }
+		    },
 		});
 
 		let [status, drives, tapes_list] = await Promise.all([status_fut, drives_fut, tapes_fut]);
-- 
2.20.1

[pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: fixup for conditional

[Dominik Csapak]

the statement !a === "somestring" cannot be true since
!a is either true or false and thus not a string

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 5a1c6073..05ca8892 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -518,7 +518,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	control: {
 	    'grid[reference=drives]': {
 		cellclick: function(table, td, ci, rec, tr, ri, e) {
-		    if (!e.position.column.dataIndex === 'state') {
+		    if (e.position.column.dataIndex !== 'state') {
 			return;
 		    }
 
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape: fix eslint warnings (trailing comma)

[Dietmar Maurer]

applied both patches