public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/3] ui: tape/ChangerStatus: adapt load/unload to WorkerTask
Date: Thu, 18 Feb 2021 09:18:09 +0100	[thread overview]
Message-ID: <20210218081809.9182-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210218081809.9182-1-d.csapak@proxmox.com>

those are now workertasks (behind a 'POST' request), so show the
progress with the upid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index c00ad979..d87b15f5 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -117,9 +117,12 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 
 	    Ext.create('Proxmox.window.Edit', {
 		isCreate: true,
+		autoShow: true,
 		submitText: gettext('OK'),
 		title: gettext('Load Media into Drive'),
 		url: `/api2/extjs/tape/drive`,
+		showProgress: true,
+		method: 'POST',
 		submitUrl: function(url, values) {
 		    let drive = values.drive;
 		    delete values.drive;
@@ -145,25 +148,26 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 			me.reload();
 		    },
 		},
-	    }).show();
+	    });
 	},
 
 	unload: async function(view, rI, cI, button, el, record) {
 	    let me = this;
 	    let drive = record.data.name;
-	    let driveGrid = me.lookup('drives');
-	    Proxmox.Utils.setErrorMask(driveGrid, true);
 	    try {
-		await PBS.Async.api2({
-		    method: 'PUT',
+		let response = await PBS.Async.api2({
+		    method: 'POST',
 		    timeout: 5*60*1000,
 		    url: `/api2/extjs/tape/drive/${encodeURIComponent(drive)}/unload`,
 		});
-		Proxmox.Utils.setErrorMask(driveGrid);
-		me.reload();
+
+		Ext.create('Proxmox.window.TaskProgress', {
+		    autoShow: true,
+		    upid: response.result.data,
+		    taskDone: () => me.reload(),
+		});
 	    } catch (error) {
 		Ext.Msg.alert(gettext('Error'), error);
-		Proxmox.Utils.setErrorMask(driveGrid);
 		me.reload();
 	    }
 	},
-- 
2.20.1





  parent reply	other threads:[~2021-02-18  8:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18  8:18 [pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/ChangerStatus: add Inventory column to drives/import-export Dominik Csapak
2021-02-18  8:18 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: tape/ChangerStatus: rename 'slot' column to 'id' Dominik Csapak
2021-02-18  8:18 ` Dominik Csapak [this message]
2021-02-18  8:50 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] ui: tape/ChangerStatus: add Inventory column to drives/import-export Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210218081809.9182-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal