From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/ChangerStatus: add Inventory column to drives/import-export
Date: Thu, 18 Feb 2021 09:18:07 +0100 [thread overview]
Message-ID: <20210218081809.9182-1-d.csapak@proxmox.com> (raw)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/ChangerStatus.js | 52 +++++++++++++++++++++++++--------------
1 file changed, 33 insertions(+), 19 deletions(-)
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index c51dea4b..9837481b 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -470,6 +470,26 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
Proxmox.Utils.setErrorMask(me.lookup('content'), err);
}
},
+
+ renderIsLabeled: function(value, mD, record) {
+ if (!record.data['label-text']) {
+ return "";
+ }
+
+ if (record.data['label-text'].startsWith("CLN")) {
+ return "";
+ }
+
+ if (!value) {
+ return gettext('Not Labeled');
+ }
+
+ let status = record.data.status;
+ if (record.data.pool) {
+ return `${status} (${record.data.pool})`;
+ }
+ return status;
+ },
},
listeners: {
@@ -551,26 +571,8 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
{
text: gettext('Inventory'),
dataIndex: 'is-labeled',
+ renderer: 'renderIsLabeled',
flex: 1,
- renderer: function(value, mD, record) {
- if (!record.data['label-text']) {
- return "";
- }
-
- if (record.data['label-text'].startsWith("CLN")) {
- return "";
- }
-
- if (!value) {
- return gettext('Not Labeled');
- }
-
- let status = record.data.status;
- if (record.data.pool) {
- return `${status} (${record.data.pool})`;
- }
- return status;
- },
},
{
text: gettext('Actions'),
@@ -626,6 +628,12 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
flex: 1,
renderer: (value) => value || '',
},
+ {
+ text: gettext('Inventory'),
+ dataIndex: 'is-labeled',
+ renderer: 'renderIsLabeled',
+ flex: 1,
+ },
{
text: gettext("Name"),
sortable: true,
@@ -716,6 +724,12 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
renderer: (value) => value || '',
flex: 1,
},
+ {
+ text: gettext('Inventory'),
+ dataIndex: 'is-labeled',
+ renderer: 'renderIsLabeled',
+ flex: 1,
+ },
{
text: gettext('Actions'),
xtype: 'actioncolumn',
--
2.20.1
next reply other threads:[~2021-02-18 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 8:18 Dominik Csapak [this message]
2021-02-18 8:18 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: tape/ChangerStatus: rename 'slot' column to 'id' Dominik Csapak
2021-02-18 8:18 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: tape/ChangerStatus: adapt load/unload to WorkerTask Dominik Csapak
2021-02-18 8:50 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] ui: tape/ChangerStatus: add Inventory column to drives/import-export Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218081809.9182-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox