public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/TapeInventory: change to regular store
Date: Mon, 15 Feb 2021 15:22:21 +0100	[thread overview]
Message-ID: <20210215142223.11140-1-d.csapak@proxmox.com> (raw)

listing the media can potentially hang (changer status), so do not
reload in the background, only on activate

also increase the timeout to 5 minutes and add a reload button

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/TapeInventory.js | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/www/tape/TapeInventory.js b/www/tape/TapeInventory.js
index 4bac4072..c641e492 100644
--- a/www/tape/TapeInventory.js
+++ b/www/tape/TapeInventory.js
@@ -18,6 +18,7 @@ Ext.define('pbs-model-tapes', {
     proxy: {
 	type: 'proxmox',
 	url: '/api2/json/tape/media/list',
+	timeout: 5*60*1000,
     },
 });
 
@@ -71,35 +72,26 @@ Ext.define('PBS.TapeManagement.TapeInventory', {
 	},
 
 	reload: function() {
-	    this.getView().getStore().rstore.load();
-	},
-
-	stopStore: function() {
-	    this.getView().getStore().rstore.stopUpdate();
-	},
-
-	startStore: function() {
-	    this.getView().getStore().rstore.startUpdate();
+	    this.getView().getStore().load();
 	},
     },
 
     listeners: {
-	beforedestroy: 'stopStore',
-	deactivate: 'stopStore',
-	activate: 'startStore',
+	activate: 'reload',
     },
 
     store: {
-	type: 'diff',
-	rstore: {
-	    type: 'update',
-	    storeid: 'proxmox-tape-tapes',
-	    model: 'pbs-model-tapes',
-	},
+	storeid: 'proxmox-tape-tapes',
+	model: 'pbs-model-tapes',
 	sorters: 'label-text',
     },
 
     tbar: [
+	{
+	    text: gettext('Reload'),
+	    handler: 'reload',
+	},
+	'-',
 	{
 	    xtype: 'proxmoxButton',
 	    text: gettext('Set Tape Location'),
-- 
2.20.1





             reply	other threads:[~2021-02-15 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 14:22 Dominik Csapak [this message]
2021-02-15 14:22 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: tape/TapeInventory: add 'Add Tape' button Dominik Csapak
2021-02-15 14:22 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: tape/TapeManagement: change Text of Backup/Tape Inventory Dominik Csapak
2021-02-16  7:34 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] ui: tape/TapeInventory: change to regular store Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210215142223.11140-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal