[pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: increase timeout for api calls

[pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: increase timeout for api calls

[Dominik Csapak]

since tape commands can take a while and we do not want to change
all of those to worker tasks, increase the timeout to 5 minutes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 76677158..3a9f4885 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -138,6 +138,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	    try {
 		await PBS.Async.api2({
 		    method: 'PUT',
+		    timeout: 5*60*1000,
 		    url: `/api2/extjs/tape/drive/${encodeURIComponent(drive)}/unload`,
 		});
 		Proxmox.Utils.setErrorMask(view);
@@ -156,6 +157,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	    method = method || 'GET';
 	    Proxmox.Utils.API2Request({
 		url: `/api2/extjs/tape/drive/${driveid}/${command}`,
+		timeout: 5*60*1000,
 		method,
 		waitMsgTarget: view,
 		params,
@@ -384,13 +386,16 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 		Proxmox.Utils.setErrorMask(view, true);
 		Proxmox.Utils.setErrorMask(me.lookup('content'));
 		let status_fut = PBS.Async.api2({
+		    timeout: 5*60*1000,
 		    url: `/api2/extjs/tape/changer/${encodeURIComponent(changer)}/status`,
 		});
 		let drives_fut = PBS.Async.api2({
+		    timeout: 5*60*1000,
 		    url: `/api2/extjs/tape/drive?changer=${encodeURIComponent(changer)}`,
 		});
 
 		let tapes_fut = PBS.Async.api2({
+		    timeout: 5*60*1000,
 		    url: '/api2/extjs/tape/media/list',
 		});
 
-- 
2.20.1

[pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: use whole drives grid for masking on unload

[Dominik Csapak]

instead of just the tableview

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/ChangerStatus.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 3a9f4885..017759c7 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -134,18 +134,19 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
 	unload: async function(view, rI, cI, button, el, record) {
 	    let me = this;
 	    let drive = record.data.name;
-	    Proxmox.Utils.setErrorMask(view, true);
+	    let driveGrid = me.lookup('drives');
+	    Proxmox.Utils.setErrorMask(driveGrid, true);
 	    try {
 		await PBS.Async.api2({
 		    method: 'PUT',
 		    timeout: 5*60*1000,
 		    url: `/api2/extjs/tape/drive/${encodeURIComponent(drive)}/unload`,
 		});
-		Proxmox.Utils.setErrorMask(view);
+		Proxmox.Utils.setErrorMask(driveGrid);
 		me.reload();
 	    } catch (error) {
 		Ext.Msg.alert(gettext('Error'), error);
-		Proxmox.Utils.setErrorMask(view);
+		Proxmox.Utils.setErrorMask(driveGrid);
 		me.reload();
 	    }
 	},
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: increase timeout for api calls

[Dietmar Maurer]

applied both patches