From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: increase timeout for api calls
Date: Mon, 15 Feb 2021 12:18:19 +0100 [thread overview]
Message-ID: <20210215111820.18378-1-d.csapak@proxmox.com> (raw)
since tape commands can take a while and we do not want to change
all of those to worker tasks, increase the timeout to 5 minutes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/ChangerStatus.js | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
index 76677158..3a9f4885 100644
--- a/www/tape/ChangerStatus.js
+++ b/www/tape/ChangerStatus.js
@@ -138,6 +138,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
try {
await PBS.Async.api2({
method: 'PUT',
+ timeout: 5*60*1000,
url: `/api2/extjs/tape/drive/${encodeURIComponent(drive)}/unload`,
});
Proxmox.Utils.setErrorMask(view);
@@ -156,6 +157,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
method = method || 'GET';
Proxmox.Utils.API2Request({
url: `/api2/extjs/tape/drive/${driveid}/${command}`,
+ timeout: 5*60*1000,
method,
waitMsgTarget: view,
params,
@@ -384,13 +386,16 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
Proxmox.Utils.setErrorMask(view, true);
Proxmox.Utils.setErrorMask(me.lookup('content'));
let status_fut = PBS.Async.api2({
+ timeout: 5*60*1000,
url: `/api2/extjs/tape/changer/${encodeURIComponent(changer)}/status`,
});
let drives_fut = PBS.Async.api2({
+ timeout: 5*60*1000,
url: `/api2/extjs/tape/drive?changer=${encodeURIComponent(changer)}`,
});
let tapes_fut = PBS.Async.api2({
+ timeout: 5*60*1000,
url: '/api2/extjs/tape/media/list',
});
--
2.20.1
next reply other threads:[~2021-02-15 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 11:18 Dominik Csapak [this message]
2021-02-15 11:18 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/ChangerStatus: use whole drives grid for masking on unload Dominik Csapak
2021-02-15 11:41 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: tape/ChangerStatus: increase timeout for api calls Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215111820.18378-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox