From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/BackupOverview: do not iterate over empty tapes
Date: Tue, 9 Feb 2021 15:40:42 +0100 [thread overview]
Message-ID: <20210209144044.17782-1-d.csapak@proxmox.com> (raw)
tapes not belonging to a pool cannot contain data, so skip them
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/BackupOverview.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/tape/BackupOverview.js b/www/tape/BackupOverview.js
index 6659d3ff..f4eb6654 100644
--- a/www/tape/BackupOverview.js
+++ b/www/tape/BackupOverview.js
@@ -46,6 +46,9 @@ Ext.define('PBS.TapeManagement.BackupOverview', {
for (const entry of content_response.result.data) {
let pool = entry.pool;
+ if (pool === undefined) {
+ continue; // pools not belonging to a pool cannot contain data
+ }
let media_set = entry['media-set-name'];
if (data[pool] === undefined) {
data[pool] = {};
--
2.20.1
next reply other threads:[~2021-02-09 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 14:40 Dominik Csapak [this message]
2021-02-09 14:40 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: tape/TapeInventory: show expired status Dominik Csapak
2021-02-09 14:40 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: tape/ChangerStatus: show more inventory info for tapes in slots Dominik Csapak
2021-02-10 5:22 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] ui: tape/BackupOverview: do not iterate over empty tapes Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209144044.17782-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox