[pbs-devel] [PATCH v2 1/2] ui: autofocus after rendering text fields for 2fa

[pbs-devel] [PATCH v2 1/2] ui: autofocus after rendering text fields for 2fa

[Oguz Bektas]

Co-Authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---

yes indeed, much better with the arrow function, thanks thomas :)

 www/LoginView.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/LoginView.js b/www/LoginView.js
index f7380339..c7f3e857 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -338,6 +338,7 @@ Ext.define('PBS.login.TfaWindow', {
 		    // non-visible tab, so we can just directly use the valid param
 		    this.getViewModel().set('canConfirm', valid);
 		},
+		afterrender: field => field.focus(), // ensure focus after initial render
 	    },
 	},
 
-- 
2.20.1

[pbs-devel] [PATCH 2/2] ui: wrap regexText in gettext() for translations

[Oguz Bektas]

also fix a small typo in recovery keys text

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 www/LoginView.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/LoginView.js b/www/LoginView.js
index c7f3e857..4b101425 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -525,7 +525,7 @@ Ext.define('PBS.login.TfaWindow', {
 			reference: 'totp',
 			allowBlank: false,
 			regex: /^[0-9]{6}$/,
-			regexText: 'TOTP codes consist of six decimal digits',
+			regexText: gettext('TOTP codes consist of six decimal digits'),
 		    },
 		],
 	    },
@@ -552,7 +552,7 @@ Ext.define('PBS.login.TfaWindow', {
 			reference: 'recoveryKey',
 			allowBlank: false,
 			regex: /^[0-9a-f]{4}(-[0-9a-f]{4}){3}$/,
-			regexText: 'Does not looks like a valid recovery key',
+			regexText: gettext('Does not look like a valid recovery key'),
 		    },
 		    {
 			xtype: 'box',
-- 
2.20.1

[pbs-devel] applied: [PATCH v2 1/2] ui: autofocus after rendering text fields for 2fa

[Thomas Lamprecht]

On 04.02.21 16:32, Oguz Bektas wrote:
> Co-Authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Tested-by: Oguz Bektas <o.bektas@proxmox.com>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> 
> yes indeed, much better with the arrow function, thanks thomas :)
> 
>  www/LoginView.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks for testing that approach!

[pbs-devel] applied: [PATCH 2/2] ui: wrap regexText in gettext() for translations

[Thomas Lamprecht]

On 04.02.21 16:32, Oguz Bektas wrote:
> also fix a small typo in recovery keys text
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  www/LoginView.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!