From: Oguz Bektas <o.bektas@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Oguz Bektas <o.bektas@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [pbs-devel] [PATCH v2 1/2] ui: autofocus after rendering text fields for 2fa
Date: Thu, 4 Feb 2021 16:32:46 +0100 [thread overview]
Message-ID: <20210204153247.1093829-1-o.bektas@proxmox.com> (raw)
Co-Authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
yes indeed, much better with the arrow function, thanks thomas :)
www/LoginView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index f7380339..c7f3e857 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -338,6 +338,7 @@ Ext.define('PBS.login.TfaWindow', {
// non-visible tab, so we can just directly use the valid param
this.getViewModel().set('canConfirm', valid);
},
+ afterrender: field => field.focus(), // ensure focus after initial render
},
},
--
2.20.1
next reply other threads:[~2021-02-04 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 15:32 Oguz Bektas [this message]
2021-02-04 15:32 ` [pbs-devel] [PATCH 2/2] ui: wrap regexText in gettext() for translations Oguz Bektas
2021-02-05 5:56 ` [pbs-devel] applied: " Thomas Lamprecht
2021-02-05 5:56 ` [pbs-devel] applied: [PATCH v2 1/2] ui: autofocus after rendering text fields for 2fa Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204153247.1093829-1-o.bektas@proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox