From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 04/15] api2/tape: add missing protected to some api calls
Date: Wed, 27 Jan 2021 11:33:50 +0100 [thread overview]
Message-ID: <20210127103401.32535-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210127103401.32535-1-d.csapak@proxmox.com>
they need root permission either to access the changer/drive or to
modify the config
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/api2/config/media_pool.rs | 3 +++
src/api2/tape/backup.rs | 1 +
src/api2/tape/changer.rs | 2 ++
src/api2/tape/drive.rs | 11 ++++++++++-
src/api2/tape/media.rs | 2 ++
5 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/api2/config/media_pool.rs b/src/api2/config/media_pool.rs
index d155f268..33e4993e 100644
--- a/src/api2/config/media_pool.rs
+++ b/src/api2/config/media_pool.rs
@@ -28,6 +28,7 @@ use crate::{
};
#[api(
+ protected: true,
input: {
properties: {
name: {
@@ -153,6 +154,7 @@ pub enum DeletableProperty {
}
#[api(
+ protected: true,
input: {
properties: {
name: {
@@ -231,6 +233,7 @@ pub fn update_pool(
}
#[api(
+ protected: true,
input: {
properties: {
name: {
diff --git a/src/api2/tape/backup.rs b/src/api2/tape/backup.rs
index 6aa12d56..ea05e6a3 100644
--- a/src/api2/tape/backup.rs
+++ b/src/api2/tape/backup.rs
@@ -43,6 +43,7 @@ use crate::{
};
#[api(
+ protected: true,
input: {
properties: {
store: {
diff --git a/src/api2/tape/changer.rs b/src/api2/tape/changer.rs
index 232f0127..f79a7ee0 100644
--- a/src/api2/tape/changer.rs
+++ b/src/api2/tape/changer.rs
@@ -33,6 +33,7 @@ use crate::{
#[api(
+ protected: true,
input: {
properties: {
name: {
@@ -106,6 +107,7 @@ pub async fn get_status(name: String) -> Result<Vec<MtxStatusEntry>, Error> {
}
#[api(
+ protected: true,
input: {
properties: {
name: {
diff --git a/src/api2/tape/drive.rs b/src/api2/tape/drive.rs
index a88ef827..936bc528 100644
--- a/src/api2/tape/drive.rs
+++ b/src/api2/tape/drive.rs
@@ -68,6 +68,7 @@ use crate::{
};
#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -150,6 +151,7 @@ pub async fn export_media(drive: String, label_text: String) -> Result<u64, Erro
}
#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -313,6 +315,7 @@ pub async fn eject_media(drive: String) -> Result<(), Error> {
}
#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -497,7 +500,8 @@ pub async fn restore_key(
}).await?
}
- #[api(
+#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -575,6 +579,7 @@ pub async fn read_label(
}
#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -793,6 +798,7 @@ pub fn update_inventory(
#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -911,6 +917,7 @@ fn barcode_label_media_worker(
}
#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -938,6 +945,7 @@ pub fn cartridge_memory(drive: String) -> Result<Vec<MamAttribute>, Error> {
}
#[api(
+ protected: true,
input: {
properties: {
drive: {
@@ -961,6 +969,7 @@ pub fn volume_statistics(drive: String) -> Result<Lp17VolumeStatistics, Error> {
}
#[api(
+ protected: true,
input: {
properties: {
drive: {
diff --git a/src/api2/tape/media.rs b/src/api2/tape/media.rs
index 70af454c..d520288f 100644
--- a/src/api2/tape/media.rs
+++ b/src/api2/tape/media.rs
@@ -38,6 +38,7 @@ use crate::{
};
#[api(
+ protected: true,
input: {
properties: {
pool: {
@@ -244,6 +245,7 @@ pub struct MediaContentListFilter {
}
#[api(
+ protected: true,
input: {
properties: {
"filter": {
--
2.20.1
next prev parent reply other threads:[~2021-01-27 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 10:33 [pbs-devel] [PATCH proxmox-backup 00/15] implement first version of tape gui Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 01/15] api2/types/tape/drive: add changer_drivenum Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 02/15] api2/tape/changer: add get_drives api call Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 03/15] api2/tape/drive: reorganize drive api Dominik Csapak
2021-01-27 10:33 ` Dominik Csapak [this message]
2021-01-27 17:47 ` [pbs-devel] [PATCH proxmox-backup 04/15] api2/tape: add missing protected to some api calls Dietmar Maurer
2021-01-28 8:05 ` Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 05/15] api2/tape/drive: add load_media as api call Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 06/15] api2/tape/drive: change methods of some api calls from put to get Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 07/15] api2/config/{drive, changer}: prevent adding same device multiple times Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 08/15] ui: tape: add form fields Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 09/15] ui: tape: add Edit Windows Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 10/15] ui: tape: add BackupOverview Panel Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 11/15] ui: tape: add ChangerStatus panel Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 12/15] ui: tape: add DriveConfig panel Dominik Csapak
2021-01-27 10:33 ` [pbs-devel] [PATCH proxmox-backup 13/15] ui: tape: add PoolConfig Dominik Csapak
2021-01-27 10:34 ` [pbs-devel] [PATCH proxmox-backup 14/15] ui: tape: move TapeManagement.js to tape dir Dominik Csapak
2021-01-27 10:34 ` [pbs-devel] [PATCH proxmox-backup 15/15] ui: tape: use panels in tape interface Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127103401.32535-5-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox