From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 0/8] clippy fixes
Date: Wed, 20 Jan 2021 17:23:47 +0100 [thread overview]
Message-ID: <20210120162355.2750802-1-f.gruenbichler@proxmox.com> (raw)
non-trivial clippy fixes and stuff I found while fixing clippy issues.
the remainder of warnings are now:
- one derive_hash_xor_eq (Authid)
- one module_inception (rrd)
- one missing_safety_docs
- one wrong_self_convention (to_canonical_json not taking &self)
- plenty complex types, too many arguments and missing Default impl when
types have a fn new() without args
which require individual attention to decide whether to refactor/fix, or
allow them.
when writing new commits, the following should cut down on the noise
until all of the above are addressed:
$ cargo clippy -- --allow clippy::type_complexity --allow clippy::new_without_default --allow clippy::too_many_arguments
Fabian Grünbichler (8):
clippy: add is_empty() when len() is implemented
clippy: fix Mutex with unused value
clippy: rewrite comparison chains
clippy: rewrite ifs with identical return values
apt: let api handle optional bool with default
rework GC traversal error handling
http-client: fix typoed ticket cache condition
http-client: further clippy cleanups
src/api2/access.rs | 32 +++++++++++++-------------------
src/api2/backup/environment.rs | 4 +++-
src/api2/node/apt.rs | 7 ++-----
src/api2/node/dns.rs | 2 +-
src/api2/node/tasks.rs | 16 ++++++----------
src/backup/chunk_store.rs | 4 ++--
src/backup/chunk_stream.rs | 7 ++-----
src/backup/datastore.rs | 18 ++++++++++--------
src/client/http_client.rs | 10 +++++-----
src/config/network/parser.rs | 1 +
src/tools/acl.rs | 9 +++++++--
src/tools/lru_cache.rs | 5 +++++
12 files changed, 57 insertions(+), 58 deletions(-)
--
2.20.1
next reply other threads:[~2021-01-20 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 16:23 Fabian Grünbichler [this message]
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 1/8] clippy: add is_empty() when len() is implemented Fabian Grünbichler
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 2/8] clippy: fix Mutex with unused value Fabian Grünbichler
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 3/8] clippy: rewrite comparison chains Fabian Grünbichler
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 4/8] clippy: rewrite ifs with identical return values Fabian Grünbichler
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 5/8] apt: let api handle optional bool with default Fabian Grünbichler
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 6/8] rework GC traversal error handling Fabian Grünbichler
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 7/8] http-client: fix typoed ticket cache condition Fabian Grünbichler
2021-01-20 16:23 ` [pbs-devel] [PATCH proxmox-backup 8/8] http-client: further clippy cleanups Fabian Grünbichler
2021-01-25 10:52 ` [pbs-devel] applied series: [PATCH proxmox-backup 0/8] clippy fixes Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120162355.2750802-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox