public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 3/4] ui: remote edit: Error as symbol to the right
Date: Tue, 19 Jan 2021 12:09:14 +0100	[thread overview]
Message-ID: <20210119110915.18864-4-d.jaeger@proxmox.com> (raw)
In-Reply-To: <20210119110915.18864-1-d.jaeger@proxmox.com>

On error, a symbol appears to the right of the textfield.
Then every error message appears there.

This way users can
1. Hover over the error symbol to read the error message
2. Hover over the label or the field to see the regular tooltip

So this avoids the problem, that the error message hides the regular tooltip
when users hover over the textfield.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 www/window/RemoteEdit.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 391b10bc..7fb3a952 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -40,6 +40,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		cbind: {
 		    editable: '{isCreate}',
 		},
+		msgTarget: 'side',
 		autoEl: {
 		    tag: 'div',
 		    'data-qtip': gettext('A unique name to identify this remote.'),
@@ -53,6 +54,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		submitValue: false,
 		vtype: 'HostPort',
 		fieldLabel: gettext('Host'),
+		msgTarget: 'side',
 		autoEl: {
 		    tag: 'div',
 		    'data-qtip': gettext('The DNS or IP address of the remote, optionally with a port.'),
@@ -104,6 +106,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		afterLabelTextTpl: " *",
 		name: 'auth-id',
 		fieldLabel: gettext('Auth ID'),
+		msgTarget: 'side',
 		autoEl: {
 		    tag: 'div',
 		    'data-qtip': gettext('For example: admin@pbs.'),
@@ -114,6 +117,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		inputType: 'password',
 		fieldLabel: gettext('Password'),
 		name: 'password',
+		msgTarget: 'side',
 		cbind: {
 		    emptyText: '{passwordEmptyText}',
 		    allowBlank: '{!isCreate}',
-- 
2.20.1




  parent reply	other threads:[~2021-01-19 11:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 11:09 [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 1/4] ui: remote edit: Add tooltips Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 2/4] ui: remote edit: Add asterisks Dominic Jäger
2021-01-19 11:09 ` Dominic Jäger [this message]
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: remote edit: Change asterisk color Dominic Jäger
2021-01-26 10:34 ` [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas Dominik Csapak
2021-01-27 10:55   ` Dominic Jäger
2021-01-27 13:57     ` Dominik Csapak
2021-01-27 14:39       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210119110915.18864-4-d.jaeger@proxmox.com \
    --to=d.jaeger@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal