From: Oguz Bektas <o.bektas@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 proxmox-backup 2/2] access: restrictions for editing passwords
Date: Wed, 13 Jan 2021 12:27:36 +0100 [thread overview]
Message-ID: <20210113112736.307324-2-o.bektas@proxmox.com> (raw)
In-Reply-To: <20210113112736.307324-1-o.bektas@proxmox.com>
this endpoint isn't used anywhere yet, but it's better to make it
consistent with `update_user` password behavior.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v1:
* change this for behavior consistency in case it gets used
src/api2/access.rs | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/api2/access.rs b/src/api2/access.rs
index 8866c944..4d485a80 100644
--- a/src/api2/access.rs
+++ b/src/api2/access.rs
@@ -245,7 +245,7 @@ fn create_ticket(
},
},
access: {
- description: "Anybody is allowed to change there own password. In addition, users with 'Permissions:Modify' privilege may change any password.",
+ description: "Anybody is allowed to change their own password. In addition, users with 'Permissions:Modify' privilege may change any password from @pbs realm.",
permission: &Permission::Anybody,
},
)]
@@ -271,17 +271,16 @@ fn change_password(
let mut allowed = userid == *current_user;
- if current_user == "root@pam" {
- allowed = true;
- }
-
if !allowed {
let user_info = CachedUserInfo::new()?;
let privs = user_info.lookup_privs(¤t_auth, &[]);
- if (privs & PRIV_PERMISSIONS_MODIFY) != 0 {
+ if user_info.is_superuser(¤t_auth) {
allowed = true;
}
- }
+ if (privs & PRIV_PERMISSIONS_MODIFY) != 0 && userid.realm() != "pam" {
+ allowed = true;
+ }
+ };
if !allowed {
bail!("you are not authorized to change the password.");
--
2.20.1
next prev parent reply other threads:[~2021-01-13 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 11:27 [pbs-devel] [PATCH v2 proxmox-backup 1/2] access: limit editing pam credentials to superuser Oguz Bektas
2021-01-13 11:27 ` Oguz Bektas [this message]
2021-01-13 12:07 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113112736.307324-2-o.bektas@proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox