* [pbs-devel] [PATCH proxmox-backup] fix #3245: only use default schedule for new jobs
@ 2021-01-12 9:21 Dominik Csapak
2021-01-12 9:54 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-01-12 9:21 UTC (permalink / raw)
To: pbs-devel
an empty schedule means 'none', so do not fill it with the default
in case we edit an existing job (like we do already for sync jobs)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/window/VerifyJobEdit.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js
index 2a22e3d6..40db207d 100644
--- a/www/window/VerifyJobEdit.js
+++ b/www/window/VerifyJobEdit.js
@@ -23,6 +23,7 @@ Ext.define('PBS.window.VerifyJobEdit', {
me.isCreate = !id;
me.url = id ? `${baseurl}/${id}` : baseurl;
me.method = id ? 'PUT' : 'POST';
+ me.scheduleValue = id ? null : 'daily';
me.autoLoad = !!id;
me.editDatastore = me.datastore === undefined && me.isCreate;
return { };
@@ -64,8 +65,8 @@ Ext.define('PBS.window.VerifyJobEdit', {
name: 'schedule',
fieldLabel: gettext('Schedule'),
emptyText: gettext('none (disabled)'),
- value: 'daily',
cbind: {
+ value: '{scheduleValue}',
deleteEmpty: '{!isCreate}',
},
},
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] fix #3245: only use default schedule for new jobs
2021-01-12 9:21 [pbs-devel] [PATCH proxmox-backup] fix #3245: only use default schedule for new jobs Dominik Csapak
@ 2021-01-12 9:54 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-01-12 9:54 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
On 12.01.21 10:21, Dominik Csapak wrote:
> an empty schedule means 'none', so do not fill it with the default
> in case we edit an existing job (like we do already for sync jobs)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/window/VerifyJobEdit.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
this was already applied by Dietmar, just noting so that not another tries to
re-apply it ;)
FWIW, adding an explicit enable checkbox and making the schedule required when
that box is checked could be more user friendly - backend behaviour would not
need to change - just a thought.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-12 9:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 9:21 [pbs-devel] [PATCH proxmox-backup] fix #3245: only use default schedule for new jobs Dominik Csapak
2021-01-12 9:54 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox