public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] backup/datastore: really lock manifest on delete
Date: Wed, 2 Dec 2020 14:40:05 +0100	[thread overview]
Message-ID: <20201202134005.zuufmg5op3nftnsu@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20201202131957.17051-1-d.csapak@proxmox.com>

applied this one

On Wed, Dec 02, 2020 at 02:19:56PM +0100, Dominik Csapak wrote:
> 'lock_manifest' returns a Result<File, Error> so we always got the result,
> even when we did not get the lock, but we acted like we had.
> 
> bubble the locking error up
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/backup/datastore.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
> index e6be1f67..0f74ac3c 100644
> --- a/src/backup/datastore.rs
> +++ b/src/backup/datastore.rs
> @@ -244,7 +244,7 @@ impl DataStore {
>          let (_guard, _manifest_guard);
>          if !force {
>              _guard = lock_dir_noblock(&full_path, "snapshot", "possibly running or in use")?;
> -            _manifest_guard = self.lock_manifest(backup_dir);
> +            _manifest_guard = self.lock_manifest(backup_dir)?;
>          }
>  
>          log::info!("removing backup snapshot {:?}", full_path);
> -- 
> 2.20.1




      parent reply	other threads:[~2020-12-02 13:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 13:19 [pbs-devel] " Dominik Csapak
2020-12-02 13:19 ` [pbs-devel] [PATCH proxmox-backup 2/2] backup/datastore: move manifest locking to /run Dominik Csapak
2020-12-02 13:50   ` Wolfgang Bumiller
2020-12-02 13:58     ` Dominik Csapak
2020-12-02 14:07       ` Wolfgang Bumiller
2020-12-02 13:40 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202134005.zuufmg5op3nftnsu@wobu-vie.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal