[pbs-devel] [PATCH proxmox-backup] client/pull: log how many groups to pull were found

[pbs-devel] [PATCH proxmox-backup] client/pull: log how many groups to pull were found

[Dominik Csapak]

if no groups were found, the task log was very confusing as it
contained no real information why nothing was synced, e.g.:

 Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee'
 Sync datastore 'local-datastore' from 'remote/datastore'
 sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end
 TASK OK

this patch simply logs how many groups were found and are about to be synced:

 Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee'
 Sync datastore 'local-datastore' from 'remote/datastore'
 found 0 groups to sync
 sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end
 TASK OK

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/client/pull.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/client/pull.rs b/src/client/pull.rs
index 5403d873..ed8256fa 100644
--- a/src/client/pull.rs
+++ b/src/client/pull.rs
@@ -498,6 +498,8 @@ pub async fn pull_store(
 
     let mut list: Vec<GroupListItem> = serde_json::from_value(result["data"].take())?;
 
+    worker.log(format!("found {} groups to sync", list.len()));
+
     list.sort_unstable_by(|a, b| {
         let type_order = a.backup_type.cmp(&b.backup_type);
         if type_order == std::cmp::Ordering::Equal {
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup] client/pull: log how many groups to pull were found

[Dietmar Maurer]

applied

> On 12/01/2020 3:01 PM Dominik Csapak <d.csapak@proxmox.com> wrote:
> 
>  
> if no groups were found, the task log was very confusing as it
> contained no real information why nothing was synced, e.g.:
> 
>  Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee'
>  Sync datastore 'local-datastore' from 'remote/datastore'
>  sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end
>  TASK OK
> 
> this patch simply logs how many groups were found and are about to be synced:
> 
>  Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee'
>  Sync datastore 'local-datastore' from 'remote/datastore'
>  found 0 groups to sync
>  sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end
>  TASK OK
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/client/pull.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/client/pull.rs b/src/client/pull.rs
> index 5403d873..ed8256fa 100644
> --- a/src/client/pull.rs
> +++ b/src/client/pull.rs
> @@ -498,6 +498,8 @@ pub async fn pull_store(
>  
>      let mut list: Vec<GroupListItem> = serde_json::from_value(result["data"].take())?;
>  
> +    worker.log(format!("found {} groups to sync", list.len()));
> +
>      list.sort_unstable_by(|a, b| {
>          let type_order = a.backup_type.cmp(&b.backup_type);
>          if type_order == std::cmp::Ordering::Equal {
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel