From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix usage of findRecord
Date: Thu, 26 Nov 2020 09:27:31 +0100 [thread overview]
Message-ID: <20201126082731.8178-1-d.csapak@proxmox.com> (raw)
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/datastore/Summary.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 1a6515ee..25a7b6e5 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -266,7 +266,8 @@ Ext.define('PBS.DataStoreSummary', {
},
failure: function(response) {
// fallback if e.g. we have no permissions to the config
- let rec = Ext.getStore('pbs-datastore-list').findRecord('store', me.datastore);
+ let rec = Ext.getStore('pbs-datastore-list')
+ .findRecord('store', me.datastore, 0, false, true, true);
if (rec) {
me.down('pbsDataStoreNotes').setNotes(rec.data.comment || "");
}
--
2.20.1
next reply other threads:[~2020-11-26 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 8:27 Dominik Csapak [this message]
2020-11-27 6:20 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126082731.8178-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox