public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Mira Limbeck <m.limbeck@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] fix running_kernel string for unknown package case
Date: Thu, 12 Nov 2020 10:52:20 +0100	[thread overview]
Message-ID: <20201112095220.26680-1-m.limbeck@proxmox.com> (raw)

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
I always use rustfmt for formatting as Wolfgang always urges us to do.
And it seems rather eager to put function arguments in new lines.

 src/api2/node/apt.rs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/api2/node/apt.rs b/src/api2/node/apt.rs
index 765ea525..09d56123 100644
--- a/src/api2/node/apt.rs
+++ b/src/api2/node/apt.rs
@@ -303,10 +303,13 @@ pub fn get_versions() -> Result<Vec<APTUpdateInfo>, Error> {
         None,
     );
 
-    let running_kernel = nix::sys::utsname::uname().release().to_owned();
+    let running_kernel = format!(
+        "running kernel: {}", 
+        nix::sys::utsname::uname().release().to_owned()
+    );
     if let Some(proxmox_backup) = pbs_packages.iter().find(|pkg| pkg.package == "proxmox-backup") {
         let mut proxmox_backup = proxmox_backup.clone();
-        proxmox_backup.extra_info = Some(format!("running kernel: {}", running_kernel));
+        proxmox_backup.extra_info = Some(running_kernel);
         packages.push(proxmox_backup);
     } else {
         packages.push(unknown_package("proxmox-backup".into(), Some(running_kernel)));
-- 
2.20.1





             reply	other threads:[~2020-11-12  9:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12  9:52 Mira Limbeck [this message]
2020-11-12 10:02 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112095220.26680-1-m.limbeck@proxmox.com \
    --to=m.limbeck@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal