From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] ui: show (local)datastore column only in global sync/verifyview
Date: Tue, 10 Nov 2020 12:58:00 +0100 [thread overview]
Message-ID: <20201110115800.30900-1-d.csapak@proxmox.com> (raw)
its rather hacky, but our cbind mixin does not support columns (yet).
if it does sometime in the future, we could use that instead
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/config/SyncView.js | 9 +++++++++
www/config/VerifyView.js | 14 ++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/www/config/SyncView.js b/www/config/SyncView.js
index 24990ff0..cac812de 100644
--- a/www/config/SyncView.js
+++ b/www/config/SyncView.js
@@ -306,4 +306,13 @@ Ext.define('PBS.config.SyncJobView', {
sortable: true,
},
],
+
+ initComponent: function() {
+ let me = this;
+ let hideLocalDatastore = !!me.datastore;
+
+ me.columns[3].hidden = hideLocalDatastore;
+
+ me.callParent();
+ },
});
diff --git a/www/config/VerifyView.js b/www/config/VerifyView.js
index 8a0ed6d4..26164555 100644
--- a/www/config/VerifyView.js
+++ b/www/config/VerifyView.js
@@ -234,6 +234,11 @@ Ext.define('PBS.config.VerifyJobView', {
flex: 1,
sortable: true,
},
+ {
+ header: gettext('Datastore'),
+ dataIndex: 'store',
+ flex: 1,
+ },
{
header: gettext('Skip Verified'),
dataIndex: 'ignore-verified',
@@ -290,4 +295,13 @@ Ext.define('PBS.config.VerifyJobView', {
sortable: true,
},
],
+
+ initComponent: function() {
+ let me = this;
+ let hideDatastore = !!me.datastore;
+
+ me.columns[1].hidden = hideDatastore;
+
+ me.callParent();
+ }
});
--
2.20.1
next reply other threads:[~2020-11-10 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 11:58 Dominik Csapak [this message]
2020-11-10 12:24 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110115800.30900-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox