public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC proxmox-backup 2/2] ui: prune: show count for rule
Date: Mon,  9 Nov 2020 15:53:08 +0100	[thread overview]
Message-ID: <20201109145308.29679-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20201109145308.29679-1-f.ebner@proxmox.com>

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 www/datastore/Prune.js | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/www/datastore/Prune.js b/www/datastore/Prune.js
index 531204f1..5ff2c459 100644
--- a/www/datastore/Prune.js
+++ b/www/datastore/Prune.js
@@ -76,9 +76,13 @@ Ext.define('PBS.DataStorePruneInputPanel', {
 		for (let backup of backups) {
 		    if (backup.keep) {
 			counter[rule]++;
-			backup.keepReason = rule;
-			if (rule !== 'keep-all' && counter[rule] >= params[rule]) {
-			    rule = nextRule();
+			if (rule !== 'keep-all') {
+			    backup.keepReason = rule + ': ' + counter[rule];
+			    if (counter[rule] >= params[rule]) {
+				rule = nextRule();
+			    }
+			} else {
+			    backup.keepReason = rule;
 			}
 		    }
 		}
@@ -212,7 +216,7 @@ Ext.define('PBS.DataStorePrune', {
 
     isCreate: true,
 
-    fieldDefaults: { labelWidth: 120 },
+    fieldDefaults: { labelWidth: 130 },
 
     initComponent: function() {
         var me = this;
-- 
2.20.1





  reply	other threads:[~2020-11-09 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 14:53 [pbs-devel] [PATCH proxmox-backup 1/2] ui: prune: show which rule keeps backup Fabian Ebner
2020-11-09 14:53 ` Fabian Ebner [this message]
2020-11-10  8:25   ` [pbs-devel] applied: [RFC proxmox-backup 2/2] ui: prune: show count for rule Thomas Lamprecht
2020-11-10  8:24 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: prune: show which rule keeps backup Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109145308.29679-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal