[pbs-devel] [PATCH proxmox-backup] www: show more ACLs in datastore panel

[pbs-devel] [PATCH proxmox-backup] www: show more ACLs in datastore panel

[Fabian Grünbichler]

since just the ACLs defined on the exact datastore path don't give
anywhere near a complete picture of who has access to it.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 www/config/ACLView.js  | 13 ++++++++++++-
 www/datastore/Panel.js |  1 -
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/www/config/ACLView.js b/www/config/ACLView.js
index bf1ea6a9..694fcf7b 100644
--- a/www/config/ACLView.js
+++ b/www/config/ACLView.js
@@ -84,11 +84,22 @@ Ext.define('PBS.config.ACLView', {
 
 	    let params = {};
 	    if (view.aclPath !== undefined) {
-		params.path = view.aclPath;
+		let pathFilter = Ext.create('Ext.util.Filter', {
+		    filterPath: view.aclPath,
+		    filterFn: function(item) {
+			let me = this;
+			return me.filterPath.startsWith(item.data.path);
+		    },
+		});
+		view.getStore().addFilter(pathFilter);
 	    }
 	    if (view.aclExact !== undefined) {
+		if (view.aclPath !== undefined) {
+		    params.path = view.aclPath;
+		}
 		params.exact = view.aclExact;
 	    }
+
 	    proxy.setExtraParams(params);
 	    Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);
 	},
diff --git a/www/datastore/Panel.js b/www/datastore/Panel.js
index 473aa50c..bca663e8 100644
--- a/www/datastore/Panel.js
+++ b/www/datastore/Panel.js
@@ -90,7 +90,6 @@ Ext.define('PBS.DataStorePanel', {
 	    itemId: 'acl',
 	    xtype: 'pbsACLView',
 	    iconCls: 'fa fa-unlock',
-	    aclExact: true,
 	    cbind: {
 		aclPath: '{aclPath}',
 	    },
-- 
2.20.1

Re: [pbs-devel] [PATCH proxmox-backup] www: show more ACLs in datastore panel

[Thomas Lamprecht]

On 09.11.20 12:31, Fabian Grünbichler wrote:
> since just the ACLs defined on the exact datastore path don't give
> anywhere near a complete picture of who has access to it.
> 


Seems like an $ anchor is missing, at least I'm getting a permission
on `/datastore/test` listed not only in that datastore view but also in
a datastore called `testnew`.

> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  www/config/ACLView.js  | 13 ++++++++++++-
>  www/datastore/Panel.js |  1 -
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/www/config/ACLView.js b/www/config/ACLView.js
> index bf1ea6a9..694fcf7b 100644
> --- a/www/config/ACLView.js
> +++ b/www/config/ACLView.js
> @@ -84,11 +84,22 @@ Ext.define('PBS.config.ACLView', {
>  
>  	    let params = {};
>  	    if (view.aclPath !== undefined) {
> -		params.path = view.aclPath;
> +		let pathFilter = Ext.create('Ext.util.Filter', {
> +		    filterPath: view.aclPath,
> +		    filterFn: function(item) {
> +			let me = this;
> +			return me.filterPath.startsWith(item.data.path);
> +		    },
> +		});
> +		view.getStore().addFilter(pathFilter);
>  	    }
>  	    if (view.aclExact !== undefined) {
> +		if (view.aclPath !== undefined) {
> +		    params.path = view.aclPath;
> +		}
>  		params.exact = view.aclExact;
>  	    }
> +
>  	    proxy.setExtraParams(params);
>  	    Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);
>  	},
> diff --git a/www/datastore/Panel.js b/www/datastore/Panel.js
> index 473aa50c..bca663e8 100644
> --- a/www/datastore/Panel.js
> +++ b/www/datastore/Panel.js
> @@ -90,7 +90,6 @@ Ext.define('PBS.DataStorePanel', {
>  	    itemId: 'acl',
>  	    xtype: 'pbsACLView',
>  	    iconCls: 'fa fa-unlock',
> -	    aclExact: true,
>  	    cbind: {
>  		aclPath: '{aclPath}',
>  	    },
> 

Re: [pbs-devel] [PATCH proxmox-backup] www: show more ACLs in datastore panel

[Fabian Grünbichler]

On November 9, 2020 1:38 pm, Thomas Lamprecht wrote:
> On 09.11.20 12:31, Fabian Grünbichler wrote:
>> since just the ACLs defined on the exact datastore path don't give
>> anywhere near a complete picture of who has access to it.
>> 
> 
> 
> Seems like an $ anchor is missing, at least I'm getting a permission
> on `/datastore/test` listed not only in that datastore view but also in
> a datastore called `testnew`.

ugh, that's (obviously!) correct, although it's not exactly a missing 
anchor. I'll send a v2..

> 
>> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
>> ---
>>  www/config/ACLView.js  | 13 ++++++++++++-
>>  www/datastore/Panel.js |  1 -
>>  2 files changed, 12 insertions(+), 2 deletions(-)
>> 
>> diff --git a/www/config/ACLView.js b/www/config/ACLView.js
>> index bf1ea6a9..694fcf7b 100644
>> --- a/www/config/ACLView.js
>> +++ b/www/config/ACLView.js
>> @@ -84,11 +84,22 @@ Ext.define('PBS.config.ACLView', {
>>  
>>  	    let params = {};
>>  	    if (view.aclPath !== undefined) {
>> -		params.path = view.aclPath;
>> +		let pathFilter = Ext.create('Ext.util.Filter', {
>> +		    filterPath: view.aclPath,
>> +		    filterFn: function(item) {
>> +			let me = this;
>> +			return me.filterPath.startsWith(item.data.path);
>> +		    },
>> +		});
>> +		view.getStore().addFilter(pathFilter);
>>  	    }
>>  	    if (view.aclExact !== undefined) {
>> +		if (view.aclPath !== undefined) {
>> +		    params.path = view.aclPath;
>> +		}
>>  		params.exact = view.aclExact;
>>  	    }
>> +
>>  	    proxy.setExtraParams(params);
>>  	    Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);
>>  	},
>> diff --git a/www/datastore/Panel.js b/www/datastore/Panel.js
>> index 473aa50c..bca663e8 100644
>> --- a/www/datastore/Panel.js
>> +++ b/www/datastore/Panel.js
>> @@ -90,7 +90,6 @@ Ext.define('PBS.DataStorePanel', {
>>  	    itemId: 'acl',
>>  	    xtype: 'pbsACLView',
>>  	    iconCls: 'fa fa-unlock',
>> -	    aclExact: true,
>>  	    cbind: {
>>  		aclPath: '{aclPath}',
>>  	    },
>> 
> 
> 
>