From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC PATCH] ui: add datastore usage also to 'datastore' navigation element
Date: Thu, 5 Nov 2020 11:57:44 +0100 [thread overview]
Message-ID: <20201105105744.30331-1-d.csapak@proxmox.com> (raw)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
it is not much, but better than nothing i suppose?
i also tried moving the whole dashboard there, but that was very
weird and confusing to use....
www/Dashboard.js | 1 +
www/NavigationTree.js | 6 ++----
www/dashboard/DataStoreStatistics.js | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/www/Dashboard.js b/www/Dashboard.js
index 6d5ccc27..55aac493 100644
--- a/www/Dashboard.js
+++ b/www/Dashboard.js
@@ -311,6 +311,7 @@ Ext.define('PBS.Dashboard', {
},
{
xtype: 'pbsDatastoresStatistics',
+ title: gettext('Datastore Usage'),
height: 250,
},
{
diff --git a/www/NavigationTree.js b/www/NavigationTree.js
index 09c58938..7eab4c33 100644
--- a/www/NavigationTree.js
+++ b/www/NavigationTree.js
@@ -84,8 +84,9 @@ Ext.define('PBS.store.NavigationStore', {
],
},
{
- text: gettext('Datastore'),
+ text: gettext('Datastores'),
iconCls: 'fa fa-archive',
+ path: 'pbsDatastoresStatistics',
id: 'datastores',
expanded: true,
expandable: false,
@@ -174,9 +175,6 @@ Ext.define('PBS.view.main.NavigationTree', {
listeners: {
itemclick: function(tl, info) {
- if (info.node.data.id === 'datastores') {
- return false;
- }
if (info.node.data.id === 'addbutton') {
let me = this;
Ext.create('PBS.DataStoreEdit', {
diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js
index 3aaa3c9b..478f576f 100644
--- a/www/dashboard/DataStoreStatistics.js
+++ b/www/dashboard/DataStoreStatistics.js
@@ -40,7 +40,7 @@ Ext.define('PBS.DatastoreStatistics', {
extend: 'Ext.grid.Panel',
alias: 'widget.pbsDatastoresStatistics',
- title: gettext('Datastore Usage'),
+ title: gettext('Datastores'),
emptyText: gettext('No Data'),
--
2.20.1
next reply other threads:[~2020-11-05 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 10:57 Dominik Csapak [this message]
2020-11-06 9:45 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105105744.30331-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox