* [pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path
@ 2020-10-20 7:00 Hannes Laimer
2020-10-20 8:35 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2020-10-20 7:00 UTC (permalink / raw)
To: pbs-devel
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
Building failed since the import of DataStoreConfig was missing,
furthermore config was not used in the function.
src/backup/datastore.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
index a856e2f4..47531bbf 100644
--- a/src/backup/datastore.rs
+++ b/src/backup/datastore.rs
@@ -57,7 +57,7 @@ impl DataStore {
}
}
- let datastore = DataStore::open_with_path(name, &path, config)?;
+ let datastore = DataStore::open_with_path(name, &path)?;
let datastore = Arc::new(datastore);
map.insert(name.to_string(), datastore.clone());
@@ -65,7 +65,7 @@ impl DataStore {
Ok(datastore)
}
- fn open_with_path(store_name: &str, path: &Path, config: DataStoreConfig) -> Result<Self, Error> {
+ fn open_with_path(store_name: &str, path: &Path) -> Result<Self, Error> {
let chunk_store = ChunkStore::open(store_name, path)?;
let gc_status = GarbageCollectionStatus::default();
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path
2020-10-20 7:00 [pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path Hannes Laimer
@ 2020-10-20 8:35 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-10-20 8:35 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Hannes Laimer
On 20.10.20 09:00, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>
> Building failed since the import of DataStoreConfig was missing,
> furthermore config was not used in the function.
>
> src/backup/datastore.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
> index a856e2f4..47531bbf 100644
> --- a/src/backup/datastore.rs
> +++ b/src/backup/datastore.rs
> @@ -57,7 +57,7 @@ impl DataStore {
> }
> }
>
> - let datastore = DataStore::open_with_path(name, &path, config)?;
> + let datastore = DataStore::open_with_path(name, &path)?;
>
> let datastore = Arc::new(datastore);
> map.insert(name.to_string(), datastore.clone());
> @@ -65,7 +65,7 @@ impl DataStore {
> Ok(datastore)
> }
>
> - fn open_with_path(store_name: &str, path: &Path, config: DataStoreConfig) -> Result<Self, Error> {
> + fn open_with_path(store_name: &str, path: &Path) -> Result<Self, Error> {
> let chunk_store = ChunkStore::open(store_name, path)?;
>
> let gc_status = GarbageCollectionStatus::default();
>
looks actually OK and thanks for catching, but it seems Fabian got to it
earlier, and pushed out a fix:
https://git.proxmox.com/?p=proxmox-backup.git;a=commitdiff;h=115d927c15f8c70442de7cc3a43e99587b499c26
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-20 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 7:00 [pbs-devel] [PATCH v1 proxmox-backup] remove not used argument config from open with path Hannes Laimer
2020-10-20 8:35 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox