From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 0/4] Locking and rustdoc improvements
Date: Thu, 15 Oct 2020 12:49:12 +0200 [thread overview]
Message-ID: <20201015104916.21170-1-s.reiter@proxmox.com> (raw)
Getting our locking into better shape, now with at least 10% more flocks/mutexes
and 14% fewer bugs! *
Order now, and you will even receive an updated documentation providing lots of
detail on how said locking actually works!
* terms and conditions may apply
With these patches applied, all interactions displayed in the table in patch 11
resolve fine in theory, in practice I couldn't trigger any of the known races we
had previously anymore either. Extra thourough review/testing still appreciated,
locking is hard...
v2:
* Drop applied patches
* Use lock file and update_manifest method for manifest
* Don't hold manifest lock across verify
* Drop Error.context() from path 1, use File::open directly instead
* Update docs for v2 changes
proxmox-backup: Stefan Reiter (4):
gc: avoid race between phase1 and forget/prune
datastore: add manifest locking
rustdoc: add crate level doc
rustdoc: overhaul backup rustdoc and add locking table
src/api2/admin/datastore.rs | 8 +-
src/api2/backup/environment.rs | 13 +--
src/backup.rs | 199 ++++++++++++++++++++-------------
src/backup/datastore.rs | 105 ++++++++++++++---
src/backup/manifest.rs | 1 +
src/backup/verify.rs | 9 +-
src/lib.rs | 5 +
7 files changed, 229 insertions(+), 111 deletions(-)
--
2.20.1
next reply other threads:[~2020-10-15 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 10:49 Stefan Reiter [this message]
2020-10-15 10:49 ` [pbs-devel] [PATCH v2 proxmox-backup 1/4] gc: avoid race between phase1 and forget/prune Stefan Reiter
2020-10-16 6:26 ` Dietmar Maurer
2020-10-15 10:49 ` [pbs-devel] [PATCH v2 proxmox-backup 2/4] datastore: add manifest locking Stefan Reiter
2020-10-16 6:33 ` Dietmar Maurer
2020-10-16 7:37 ` Dietmar Maurer
2020-10-16 7:39 ` [pbs-devel] applied: " Dietmar Maurer
2020-10-15 10:49 ` [pbs-devel] [PATCH v2 proxmox-backup 3/4] rustdoc: add crate level doc Stefan Reiter
2020-10-16 7:47 ` [pbs-devel] applied: " Dietmar Maurer
2020-10-15 10:49 ` [pbs-devel] [PATCH v2 proxmox-backup 4/4] rustdoc: overhaul backup rustdoc and add locking table Stefan Reiter
2020-10-16 7:47 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015104916.21170-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox