From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 00/14] add job based verify scheduling
Date: Wed, 14 Oct 2020 13:55:30 +0200 [thread overview]
Message-ID: <20201014115530.pwjlgmpjreygutor@olga.proxmox.com> (raw)
In-Reply-To: <20201013093309.14917-1-h.laimer@proxmox.com>
Acked code wise mostly, some cleanups afterwards would be nice, but not
worth resending the series.
On Tue, Oct 13, 2020 at 11:32:55AM +0200, Hannes Laimer wrote:
> Replaces the first implementation of scheduled verification with a new
> job-based version with additional options that may be specified through
> the web ui.
>
> Options available for verification jobs:
> * schedule when to run the job
> * set datastore on which the job should run
> * set a number of days after which a verification becomes "outdated"
> empty => verifications are valid forever
> * specify if already successfuly verified snapshots should be verified
> again even if they're not outdated(failed ones will always be done)
>
>
> v3:
> * restructure do_verification_job function
> * renamed 'verify' in config to 'verification'
> * add cbind to 'Days valid' field in frontend
>
> v2:
> * added 'Ignire Verified' column in WebUI
> * rebased onto master
> * log number of planned verification
> * ignore_verified is not optional anymore
> * adjusted default column width for 'Days valid'
> * failed verifications won't be verified again
> * use proxmox::try_block! in worker
>
>
> Hannes Laimer (14):
> add two new schemas for verification jobs
> add verification job config
> api2: add verify job config endpoint
> add do_verification_job function to verify.rs
> api2: add verification job admin endpoint
> add scheduling for verification jobs
> set a diffrent worker_type based on what is going to be
> verified(snapshot, group, ds)
> ui: add verification job view
> ui: add verification job edit window
> ui: add task descriptions for the different types of verification(job,
> snapshpt, group, ds)
> remove verify_schedule field from datastore config endpoint
> remove verify_schedule field from DatastoreConfig
> remove verify-schedule field from DataStoreEdit and DataStoreConfig
> remove old verification scheduling from proxmox-backup-proxy.rs
>
> src/api2/admin.rs | 4 +-
> src/api2/admin/datastore.rs | 5 +-
> src/api2/admin/verify.rs | 107 ++++++++++++
> src/api2/config.rs | 2 +
> src/api2/config/datastore.rs | 24 ---
> src/api2/config/verify.rs | 274 +++++++++++++++++++++++++++++++
> src/api2/types/mod.rs | 12 +-
> src/backup/verify.rs | 94 +++++++++++
> src/bin/proxmox-backup-proxy.rs | 115 ++++---------
> src/config.rs | 1 +
> src/config/datastore.rs | 6 -
> src/config/verify.rs | 189 +++++++++++++++++++++
> www/Makefile | 2 +
> www/NavigationTree.js | 6 +
> www/Utils.js | 5 +-
> www/config/DataStoreConfig.js | 2 +-
> www/config/VerifyView.js | 280 ++++++++++++++++++++++++++++++++
> www/window/DataStoreEdit.js | 9 -
> www/window/VerifyJobEdit.js | 93 +++++++++++
> 19 files changed, 1102 insertions(+), 128 deletions(-)
> create mode 100644 src/api2/admin/verify.rs
> create mode 100644 src/api2/config/verify.rs
> create mode 100644 src/config/verify.rs
> create mode 100644 www/config/VerifyView.js
> create mode 100644 www/window/VerifyJobEdit.js
>
> --
> 2.20.1
prev parent reply other threads:[~2020-10-14 11:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:32 Hannes Laimer
2020-10-13 9:32 ` [pbs-devel] [PATCH v3 proxmox-backup 01/14] add two new schemas for verification jobs Hannes Laimer
2020-10-15 16:13 ` Thomas Lamprecht
2020-10-13 9:32 ` [pbs-devel] [PATCH v3 proxmox-backup 02/14] add verification job config Hannes Laimer
2020-10-13 9:32 ` [pbs-devel] [PATCH v3 proxmox-backup 03/14] api2: add verify job config endpoint Hannes Laimer
2020-10-13 9:32 ` [pbs-devel] [PATCH v3 proxmox-backup 04/14] add do_verification_job function to verify.rs Hannes Laimer
2020-10-15 16:15 ` Thomas Lamprecht
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 05/14] api2: add verification job admin endpoint Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 06/14] add scheduling for verification jobs Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 07/14] set a diffrent worker_type based on what is going to be verified(snapshot, group, ds) Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 08/14] ui: add verification job view Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 09/14] ui: add verification job edit window Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 10/14] ui: add task descriptions for the different types of verification(job, snapshpt, group, ds) Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 11/14] remove verify_schedule field from datastore config endpoint Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 12/14] remove verify_schedule field from DatastoreConfig Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 13/14] remove verify-schedule field from DataStoreEdit and DataStoreConfig Hannes Laimer
2020-10-13 9:33 ` [pbs-devel] [PATCH v3 proxmox-backup 14/14] remove old verification scheduling from proxmox-backup-proxy.rs Hannes Laimer
2020-10-15 16:18 ` Thomas Lamprecht
2020-10-14 11:55 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014115530.pwjlgmpjreygutor@olga.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox