From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/3] Userid: simplify comparison with str
Date: Thu, 8 Oct 2020 15:37:18 +0200 [thread overview]
Message-ID: <20201008133720.2894310-1-f.gruenbichler@proxmox.com> (raw)
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/api2/types/userid.rs | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/api2/types/userid.rs b/src/api2/types/userid.rs
index 3001b1d9..f0a61031 100644
--- a/src/api2/types/userid.rs
+++ b/src/api2/types/userid.rs
@@ -397,10 +397,7 @@ impl TryFrom<String> for Userid {
impl PartialEq<str> for Userid {
fn eq(&self, rhs: &str) -> bool {
- rhs.len() > self.name_len + 2 // make sure range access below is allowed
- && rhs.starts_with(self.name().as_str())
- && rhs.as_bytes()[self.name_len] == b'@'
- && &rhs[(self.name_len + 1)..] == self.realm().as_str()
+ self.data == *rhs
}
}
--
2.20.1
next reply other threads:[~2020-10-08 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 13:37 Fabian Grünbichler [this message]
2020-10-08 13:37 ` [pbs-devel] [PATCH proxmox-backup 2/3] Userid: fix borrow/deref recursion Fabian Grünbichler
2020-10-08 13:37 ` [pbs-devel] [PATCH proxmox-backup 3/3] REST: don't print CSRF token Fabian Grünbichler
2020-10-08 13:57 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] Userid: simplify comparison with str Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008133720.2894310-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox