From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts
Date: Wed, 7 Oct 2020 11:53:25 +0200 [thread overview]
Message-ID: <20201007095325.38338-1-d.jaeger@proxmox.com> (raw)
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
v1->v2:
Make clear that the emptyTexts are not defaults
www/window/RemoteEdit.js | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 56a248e0..6515dce9 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -34,7 +34,8 @@ Ext.define('PBS.window.RemoteEdit', {
{
xtype: 'pmxDisplayEditField',
name: 'name',
- fieldLabel: gettext('Remote'),
+ fieldLabel: gettext('Remote ID'),
+ emptyText: 'E.g., new_remote',
renderer: Ext.htmlEncode,
allowBlank: false,
minLength: 4,
@@ -48,7 +49,8 @@ Ext.define('PBS.window.RemoteEdit', {
name: 'hostport',
submitValue: false,
vtype: 'HostPort',
- fieldLabel: gettext('Host'),
+ fieldLabel: gettext('Remote Address'),
+ emptyText: 'E.g., 192.168.10.10',
listeners: {
change: function(field, newvalue) {
let host = newvalue;
@@ -94,7 +96,8 @@ Ext.define('PBS.window.RemoteEdit', {
xtype: 'proxmoxtextfield',
allowBlank: false,
name: 'userid',
- fieldLabel: gettext('Userid'),
+ fieldLabel: gettext('User ID'),
+ emptyText: 'E.g., admin@pbs',
},
{
xtype: 'textfield',
@@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', {
deleteEmpty: '{!isCreate}',
},
fieldLabel: gettext('Fingerprint'),
+ emptyText: 'Server certificate SHA-256 fingerprint, required for self-signed certificates',
},
{
xtype: 'proxmoxtextfield',
--
2.20.1
next reply other threads:[~2020-10-07 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 9:53 Dominic Jäger [this message]
2020-10-07 12:03 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007095325.38338-1-d.jaeger@proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox