From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v2 4/6] ui: Dashboard/TaskSummary: refactor types and title
Date: Tue, 6 Oct 2020 12:25:26 +0200 [thread overview]
Message-ID: <20201006102528.15383-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20201006102528.15383-1-d.csapak@proxmox.com>
by moving the definition into the controller and dynamically use them
in the updateTasks function
we will reuse/extend this later
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* correctly change function signature
www/dashboard/TaskSummary.js | 33 ++++++++++++++++++++++-----------
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js
index 0cf049cd..c5095751 100644
--- a/www/dashboard/TaskSummary.js
+++ b/www/dashboard/TaskSummary.js
@@ -7,6 +7,20 @@ Ext.define('PBS.TaskSummary', {
controller: {
xclass: 'Ext.app.ViewController',
+ types: [
+ "backup",
+ "prune",
+ "garbage_collection",
+ "sync",
+ ],
+
+ titles: {
+ "backup": gettext('Backups'),
+ "prune": gettext('Prunes'),
+ "garbage_collection": gettext('Garbage collections'),
+ "sync": gettext('Syncs'),
+ },
+
render_icon: function(state, count) {
let cls = 'question';
let color = 'faded';
@@ -40,18 +54,15 @@ Ext.define('PBS.TaskSummary', {
},
},
- updateTasks: function(data) {
+ updateTasks: function(source) {
let me = this;
- data.backup.type = gettext('Backups');
- data.prune.type = gettext('Prunes');
- data.garbage_collection.type = gettext('Garbage collections');
- data.sync.type = gettext('Syncs');
- me.lookup('grid').getStore().setData([
- data.backup,
- data.prune,
- data.garbage_collection,
- data.sync,
- ]);
+ let controller = me.getController();
+ let data = [];
+ controller.types.forEach((type) => {
+ source[type].type = controller.titles[type];
+ data.push(source[type]);
+ });
+ me.lookup('grid').getStore().setData(data);
},
layout: 'fit',
--
2.20.1
next prev parent reply other threads:[~2020-10-06 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 10:25 [pbs-devel] [PATCH proxmox-backup v2 1/6] api2/types: add TaskStateType struct Dominik Csapak
2020-10-06 10:25 ` [pbs-devel] [PATCH proxmox-backup v2 2/6] api2/status: add type- and statusfilter to tasks api call Dominik Csapak
2020-10-06 10:25 ` [pbs-devel] [PATCH proxmox-backup v2 3/6] ui: implment task history limit and make it configurable Dominik Csapak
2020-10-06 10:53 ` Thomas Lamprecht
2020-10-06 11:25 ` Dominik Csapak
2020-10-06 10:25 ` Dominik Csapak [this message]
2020-10-06 10:25 ` [pbs-devel] [PATCH proxmox-backup v2 5/6] ui: Dashboard/TaskSummary: add Verifies to the Summary Dominik Csapak
2020-10-06 11:10 ` Thomas Lamprecht
2020-10-06 11:25 ` Thomas Lamprecht
2020-10-06 10:25 ` [pbs-devel] [PATCH proxmox-backup v2 6/6] ui: Dashboard/TaskSummary: show task overlay when clicking on a count Dominik Csapak
2020-10-06 14:07 ` [pbs-devel] applied-series: [PATCH proxmox-backup v2 1/6] api2/types: add TaskStateType struct Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006102528.15383-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox