public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts
Date: Tue,  6 Oct 2020 12:10:00 +0200	[thread overview]
Message-ID: <20201006101000.70009-1-d.jaeger@proxmox.com> (raw)

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 www/window/RemoteEdit.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 56a248e0..695ad422 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -24,7 +24,7 @@ Ext.define('PBS.window.RemoteEdit', {
 	me.method = name ? 'PUT' : 'POST';
 	me.autoLoad = !!name;
 	return {
-	    passwordEmptyText: me.isCreate ? '' : gettext('Unchanged'),
+	    passwordEmptyText: me.isCreate ? '•'.repeat(16) : gettext('Unchanged'),
 	};
     },
 
@@ -35,6 +35,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		xtype: 'pmxDisplayEditField',
 		name: 'name',
 		fieldLabel: gettext('Remote'),
+		emptyText: 'new_remote',
 		renderer: Ext.htmlEncode,
 		allowBlank: false,
 		minLength: 4,
@@ -49,6 +50,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		submitValue: false,
 		vtype: 'HostPort',
 		fieldLabel: gettext('Host'),
+		emptyText: '192.168.10.10',
 		listeners: {
 		    change: function(field, newvalue) {
 			let host = newvalue;
@@ -95,6 +97,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		allowBlank: false,
 		name: 'userid',
 		fieldLabel: gettext('Userid'),
+		emptyText: 'root@pam',
 	    },
 	    {
 		xtype: 'textfield',
@@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		    deleteEmpty: '{!isCreate}',
 		},
 		fieldLabel: gettext('Fingerprint'),
+		emptyText: '0f:04:9a:2d:48:23:52:5d:d5:f4:1d:9e:5d:37:8e:60:93:d8:b0:03:31:8c:5c:d5:49:ff:96:31:9e:c2:1d:74',
 	    },
 	    {
 		xtype: 'proxmoxtextfield',
@@ -124,6 +128,7 @@ Ext.define('PBS.window.RemoteEdit', {
 		    deleteEmpty: '{!isCreate}',
 		},
 		fieldLabel: gettext('Comment'),
+		emptyText: gettext('A very long comment'),
 	    },
 	],
     },
-- 
2.20.1




             reply	other threads:[~2020-10-06 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 10:10 Dominic Jäger [this message]
2020-10-06 10:22 ` Thomas Lamprecht
2020-10-07  9:53   ` Dominic Jäger
2020-10-07 11:58     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006101000.70009-1-d.jaeger@proxmox.com \
    --to=d.jaeger@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal