From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH 0/5] backup validation improvements
Date: Wed, 30 Sep 2020 15:25:17 +0200 [thread overview]
Message-ID: <20200930132522.22927-1-s.reiter@proxmox.com> (raw)
First patch skips server-side validation (existance check) of last snapshot's
chunks if the base was verified successfully at least 7 days ago. With verify
scheduling this means that users can avoid the overhead during backups by doing
weekly verifications.
The latter 4 patches (marked RFC, not sure if the idea is that sound) make the
validation happen in a seperate thread. This requires some modifications to
ParallelHandler and carries the tradeoff that we have to verify *all* chunks of
the last backup, since when the thread starts we don't know yet which ones the
client will upload and overwrite anyway.
proxmox-backup: Stefan Reiter (5):
backup: don't validate chunk existance if base was recently verified
ParallelHandler add unbounded mode
ParallelHandler: add check_abort function and handle errors during
join
ParallelHandler: exit early if this or other thread aborted
backup: validate chunk existance in background
src/api2/backup/environment.rs | 172 ++++++++++++++++++++++++---------
src/backup/verify.rs | 3 +-
src/client/pull.rs | 3 +-
src/tools/parallel_handler.rs | 68 ++++++++++---
4 files changed, 183 insertions(+), 63 deletions(-)
--
2.20.1
next reply other threads:[~2020-09-30 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 13:25 Stefan Reiter [this message]
2020-09-30 13:25 ` [pbs-devel] [PATCH proxmox-backup 1/5] backup: don't validate chunk existance if base was recently verified Stefan Reiter
2020-09-30 13:32 ` Thomas Lamprecht
2020-09-30 13:42 ` Stefan Reiter
2020-09-30 13:55 ` Thomas Lamprecht
2020-09-30 13:25 ` [pbs-devel] [RFC proxmox-backup 2/5] ParallelHandler: add unbounded mode Stefan Reiter
2020-09-30 13:25 ` [pbs-devel] [RFC proxmox-backup 3/5] ParallelHandler: add check_abort function and handle errors during join Stefan Reiter
2020-09-30 13:25 ` [pbs-devel] [RFC proxmox-backup 4/5] ParallelHandler: exit early if this or other thread aborted Stefan Reiter
2020-09-30 13:25 ` [pbs-devel] [RFC proxmox-backup 5/5] backup: validate chunk existance in background Stefan Reiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930132522.22927-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox