From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 proxmox-backup 6/6] add verification scheduling to proxmox-backup-proxy
Date: Fri, 18 Sep 2020 11:00:52 +0200 [thread overview]
Message-ID: <20200918090052.79979-7-h.laimer@proxmox.com> (raw)
In-Reply-To: <20200918090052.79979-1-h.laimer@proxmox.com>
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/bin/proxmox-backup-proxy.rs | 104 +++++++++++++++++++++++++++++++-
1 file changed, 103 insertions(+), 1 deletion(-)
diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs
index 4e49615c..1f349c8c 100644
--- a/src/bin/proxmox-backup-proxy.rs
+++ b/src/bin/proxmox-backup-proxy.rs
@@ -1,4 +1,4 @@
-use std::sync::Arc;
+use std::sync::{Arc};
use std::path::{Path, PathBuf};
use anyhow::{bail, format_err, Error};
@@ -196,6 +196,7 @@ async fn schedule_tasks() -> Result<(), Error> {
schedule_datastore_garbage_collection().await;
schedule_datastore_prune().await;
+ schedule_datastore_verification().await;
schedule_datastore_sync_jobs().await;
Ok(())
@@ -463,6 +464,107 @@ async fn schedule_datastore_prune() {
}
}
+async fn schedule_datastore_verification() {
+ use proxmox_backup::backup::{DataStore, verify_all_backups};
+ use proxmox_backup::server::{WorkerTask};
+ use proxmox_backup::config::datastore::{self, DataStoreConfig};
+ use proxmox_backup::tools::systemd::time::{
+ parse_calendar_event, compute_next_event};
+
+ let config = match datastore::config() {
+ Err(err) => {
+ eprintln!("unable to read datastore config - {}", err);
+ return;
+ }
+ Ok((config, _digest)) => config,
+ };
+
+ for (store, (_, store_config)) in config.sections {
+ let datastore = match DataStore::lookup_datastore(&store) {
+ Ok(datastore) => datastore,
+ Err(err) => {
+ eprintln!("lookup_datastore failed - {}", err);
+ continue;
+ }
+ };
+
+ let store_config: DataStoreConfig = match serde_json::from_value(store_config) {
+ Ok(c) => c,
+ Err(err) => {
+ eprintln!("datastore config from_value failed - {}", err);
+ continue;
+ }
+ };
+
+ let event_str = match store_config.verify_schedule {
+ Some(event_str) => event_str,
+ None => continue,
+ };
+
+ let event = match parse_calendar_event(&event_str) {
+ Ok(event) => event,
+ Err(err) => {
+ eprintln!("unable to parse schedule '{}' - {}", event_str, err);
+ continue;
+ }
+ };
+
+ let worker_type = "verify";
+
+ let last = match lookup_last_worker(worker_type, &store) {
+ Ok(Some(upid)) => {
+ if proxmox_backup::server::worker_is_active_local(&upid) {
+ continue;
+ }
+ upid.starttime
+ }
+ Ok(None) => 0,
+ Err(err) => {
+ eprintln!("lookup_last_job_start failed: {}", err);
+ continue;
+ }
+ };
+
+ let next = match compute_next_event(&event, last, false) {
+ Ok(Some(next)) => next,
+ Ok(None) => continue,
+ Err(err) => {
+ eprintln!("compute_next_event for '{}' failed - {}", event_str, err);
+ continue;
+ }
+ };
+
+ let now = proxmox::tools::time::epoch_i64();
+
+ if next > now { continue; }
+
+ let worker_id = store.clone();
+ let store2 = store.clone();
+ if let Err(err) = WorkerTask::new_thread(
+ worker_type,
+ Some(worker_id),
+ Userid::backup_userid().clone(),
+ false,
+ move |worker| {
+ worker.log(format!("starting verification on store {}", store2));
+ worker.log(format!("task triggered by schedule '{}'", event_str));
+ if let Ok(failed_dirs) = verify_all_backups(datastore, worker.clone()) {
+ if failed_dirs.len() > 0 {
+ worker.log("Failed to verify following snapshots:");
+ for dir in failed_dirs {
+ worker.log(format!("\t{}", dir));
+ }
+ bail!("verification failed - please check the log for details");
+ }
+ }
+ Ok(())
+ },
+ ) {
+ eprintln!("unable to start verification on store {} - {}", store, err);
+ }
+ }
+}
+
async fn schedule_datastore_sync_jobs() {
use proxmox_backup::{
--
2.20.1
next prev parent reply other threads:[~2020-09-18 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 9:00 [pbs-devel] [PATCH v2 proxmox-backup 0/6] add scheduled verification of datastore Hannes Laimer
2020-09-18 9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 1/6] api2: add VERIFY_SCHEDULE_SCHEMA Hannes Laimer
2020-09-18 9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 2/6] add verify_schedule field to DataStoreConfig Hannes Laimer
2020-09-18 9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 3/6] api2: add optional verify-schdule field to create/update datastore endpoint Hannes Laimer
2020-09-18 9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 4/6] api2: make verify_schedule deletable Hannes Laimer
2020-09-18 9:00 ` [pbs-devel] [PATCH v2 proxmox-backup 5/6] ui: add verify-schedule field to edit datastore form Hannes Laimer
2020-09-18 13:26 ` Thomas Lamprecht
2020-09-18 9:00 ` Hannes Laimer [this message]
2020-09-18 10:10 ` [pbs-devel] [PATCH v2 proxmox-backup 0/6] add scheduled verification of datastore Dominik Csapak
2020-09-18 13:23 ` Thomas Lamprecht
2020-09-18 10:13 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918090052.79979-7-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox