From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC proxmox 1/5] time: add test for leap second parsing/converting
Date: Tue, 15 Sep 2020 12:20:50 +0200 [thread overview]
Message-ID: <20200915102054.2866527-2-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20200915102054.2866527-1-f.gruenbichler@proxmox.com>
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Notes:
test fails, fixed by next patch
proxmox/src/tools/time.rs | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/proxmox/src/tools/time.rs b/proxmox/src/tools/time.rs
index 803c6c0..78d75b9 100644
--- a/proxmox/src/tools/time.rs
+++ b/proxmox/src/tools/time.rs
@@ -279,3 +279,26 @@ pub fn parse_rfc3339(i: &str) -> Result<i64, Error> {
Ok(epoch)
}).map_err(|err| format_err!("parse_rfc_3339 failed - {}", err))
}
+
+#[test]
+fn test_leap_seconds() {
+ let convert_reconvert = |epoch| {
+ let rfc3339 = epoch_to_rfc3339_utc(epoch)
+ .expect("leap second epoch to rfc3339 should work");
+
+ let parsed = parse_rfc3339(&rfc3339)
+ .expect("parsing converted leap second epoch should work");
+
+ assert_eq!(epoch, parsed);
+ };
+
+ // 2005-12-31T23:59:59Z was followed by a leap second
+ let epoch = 1136073599;
+ convert_reconvert(epoch);
+ convert_reconvert(epoch + 1);
+ convert_reconvert(epoch + 2);
+
+ let parsed = parse_rfc3339("2005-12-31T23:59:60Z")
+ .expect("parsing leap second should work");
+ assert_eq!(parsed, epoch + 1);
+}
--
2.20.1
next prev parent reply other threads:[~2020-09-15 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:20 [pbs-devel] [PATCH proxmox 0/5] time conversion tests and fixes Fabian Grünbichler
2020-09-15 10:20 ` Fabian Grünbichler [this message]
2020-09-15 11:35 ` [pbs-devel] [RFC proxmox 1/5] time: add test for leap second parsing/converting Thomas Lamprecht
2020-09-15 10:20 ` [pbs-devel] [RFC proxmox 2/5] time: allow leap seconds when parsing RFC3339 Fabian Grünbichler
2020-09-15 10:20 ` [pbs-devel] [PATCH proxmox 3/5] time: add tests for RFC3339 corner cases Fabian Grünbichler
2020-09-15 10:20 ` [pbs-devel] [PATCH proxmox 4/5] time/rfc3339: add leading zeroes for years < 1000 Fabian Grünbichler
2020-09-15 10:20 ` [pbs-devel] [PATCH proxmox 5/5] time: add tests for gmtime range Fabian Grünbichler
2020-09-15 11:48 ` [pbs-devel] applied: [PATCH proxmox 0/5] time conversion tests and fixes Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915102054.2866527-2-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox