From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v4 proxmox-backup 1/2] backup: check verify state of previous backup before allowing reuse
Date: Mon, 14 Sep 2020 10:50:18 +0200 [thread overview]
Message-ID: <20200914085019.14101-1-s.reiter@proxmox.com> (raw)
Do not allow clients to reuse chunks from the previous backup if it has
a failed validation result. This would result in a new "successful"
backup that potentially references broken chunks.
If the previous backup has not been verified, assume it is fine and
continue on.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
v4:
* check earlier in upgrade_to_backup_protocol
* update error messages to include "valid"
src/api2/backup.rs | 29 ++++++++++++++++++++++++++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/src/api2/backup.rs b/src/api2/backup.rs
index 9420b146..2b855554 100644
--- a/src/api2/backup.rs
+++ b/src/api2/backup.rs
@@ -113,7 +113,30 @@ async move {
bail!("backup owner check failed ({} != {})", userid, owner);
}
- let last_backup = BackupInfo::last_backup(&datastore.base_path(), &backup_group, true).unwrap_or(None);
+ let last_backup = {
+ let info = BackupInfo::last_backup(&datastore.base_path(), &backup_group, true).unwrap_or(None);
+ if let Some(info) = info {
+ let (manifest, _) = datastore.load_manifest(&info.backup_dir)?;
+ let verify = manifest.unprotected["verify_state"].clone();
+ match serde_json::from_value::<SnapshotVerifyState>(verify) {
+ Ok(verify) => {
+ if verify.state != "ok" {
+ // verify failed, treat as if no previous backup exists
+ None
+ } else {
+ Some(info)
+ }
+ },
+ Err(_) => {
+ // no verify state found, treat as valid
+ Some(info)
+ }
+ }
+ } else {
+ None
+ }
+ };
+
let backup_dir = BackupDir::new_with_group(backup_group.clone(), backup_time)?;
let _last_guard = if let Some(last) = &last_backup {
@@ -355,7 +378,7 @@ fn create_fixed_index(
let last_backup = match &env.last_backup {
Some(info) => info,
None => {
- bail!("cannot reuse index - no previous backup exists");
+ bail!("cannot reuse index - no valid previous backup exists");
}
};
@@ -670,7 +693,7 @@ fn download_previous(
let last_backup = match &env.last_backup {
Some(info) => info,
- None => bail!("no previous backup"),
+ None => bail!("no valid previous backup"),
};
let mut path = env.datastore.snapshot_path(&last_backup.backup_dir);
--
2.20.1
next reply other threads:[~2020-09-14 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:50 Stefan Reiter [this message]
2020-09-14 8:50 ` [pbs-devel] [PATCH v4 proxmox-backup 2/2] backup: check all referenced chunks actually exist Stefan Reiter
2020-09-15 6:09 ` Dietmar Maurer
2020-09-15 7:42 ` Thomas Lamprecht
2020-09-15 7:47 ` Dietmar Maurer
2020-09-15 8:00 ` [pbs-devel] applied: " Dietmar Maurer
2020-09-15 7:59 ` [pbs-devel] applied: [PATCH v4 proxmox-backup 1/2] backup: check verify state of previous backup before allowing reuse Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914085019.14101-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox