* [pbs-devel] [PATCH proxmox-backup] ui: fix calendarevent examples
@ 2020-09-09 14:17 Dominik Csapak
2020-09-09 17:04 ` Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-09-09 14:17 UTC (permalink / raw)
To: pbs-devel
*/x is not valid syntax, also an timespec must at least have
hours and minutes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/form/CalendarEvent.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/form/CalendarEvent.js b/www/form/CalendarEvent.js
index d05136b9..ddc8fa79 100644
--- a/www/form/CalendarEvent.js
+++ b/www/form/CalendarEvent.js
@@ -4,9 +4,9 @@ Ext.define('PBS.data.CalendarEventExamples', {
field: ['value', 'text'],
data: [
- { value: '*/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
+ { value: '*:0/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
{ value: 'hourly', text: gettext("Every hour") },
- { value: '*/2:00', text: gettext("Every two hours") },
+ { value: '0/2:00', text: gettext("Every two hours") },
{ value: '2,22:30', text: gettext("Every day") + " 02:30, 22:30" },
{ value: 'daily', text: gettext("Every day") + " 00:00" },
{ value: 'mon..fri', text: gettext("Monday to Friday") + " 00:00" },
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] ui: fix calendarevent examples
2020-09-09 14:17 [pbs-devel] [PATCH proxmox-backup] ui: fix calendarevent examples Dominik Csapak
@ 2020-09-09 17:04 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-09-09 17:04 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Dominik Csapak
On 09.09.20 16:17, Dominik Csapak wrote:
> */x is not valid syntax, also an timespec must at least have
> hours and minutes
PVE supports this (and, IIRC, this parser previously too)
https://git.proxmox.com/?p=pve-manager.git;a=blob;f=www/manager6/form/CalendarEvent.js;h=c3b9ecab7e00014bd50533056e4dc9642fdf435a;hb=HEAD
I'd like if those are kept as compatible as possible, it's really
not good if we have two similar looking schedule formats which are
incompatible...
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/form/CalendarEvent.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/www/form/CalendarEvent.js b/www/form/CalendarEvent.js
> index d05136b9..ddc8fa79 100644
> --- a/www/form/CalendarEvent.js
> +++ b/www/form/CalendarEvent.js
> @@ -4,9 +4,9 @@ Ext.define('PBS.data.CalendarEventExamples', {
>
> field: ['value', 'text'],
> data: [
> - { value: '*/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
> + { value: '*:0/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
> { value: 'hourly', text: gettext("Every hour") },
> - { value: '*/2:00', text: gettext("Every two hours") },
> + { value: '0/2:00', text: gettext("Every two hours") },
> { value: '2,22:30', text: gettext("Every day") + " 02:30, 22:30" },
> { value: 'daily', text: gettext("Every day") + " 00:00" },
> { value: 'mon..fri', text: gettext("Monday to Friday") + " 00:00" },
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 14:17 [pbs-devel] [PATCH proxmox-backup] ui: fix calendarevent examples Dominik Csapak
2020-09-09 17:04 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox