From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH v2 0/7] More flocking and race elimination
Date: Tue, 11 Aug 2020 10:50:35 +0200 [thread overview]
Message-ID: <20200811085042.30686-1-s.reiter@proxmox.com> (raw)
The previous series[0] already fixed some bugs, but it also introduced some new
ones, e.g. incomplete but not running backups were unable to be removed.
This is the next step to race-free™ backups, this time going all-in on flocks.
The 6th patch introduces locking for base backups, but also re-writes the
previous (unnecessarily complex) base-snapshot existance check, which is
therefor reverted in patch 5.
v2:
* drop applied patches
* add cleanup patches from dietmar and rewrite series on top [1]
* use new lock_dir_noblock function
* rethink prune logic w/ feedback from Fabi
[0] https://lists.proxmox.com/pipermail/pbs-devel/2020-July/000233.html
[1] https://lists.proxmox.com/pipermail/pbs-devel/2020-August/000311.html
proxmox-backup: Dietmar Maurer (2):
src/tools/fs.rs: new helper lock_dir_noblock
src/backup/backup_info.rs: remove BackupGroup lock()
Stefan Reiter (5):
datastore: prevent in-use deletion with locks instead of heuristic
backup: flock snapshot on backup start
Revert "backup: ensure base snapshots are still available after
backup"
backup: lock base snapshot and ensure existance on finish
prune: also check backup snapshot locks
src/api2/admin/datastore.rs | 2 +-
src/api2/backup.rs | 16 ++++++---
src/api2/backup/environment.rs | 17 +++-------
src/backup/backup_info.rs | 43 +----------------------
src/backup/datastore.rs | 60 ++++++++++-----------------------
src/backup/prune.rs | 50 +++++++++++++++++----------
src/bin/proxmox-backup-proxy.rs | 2 +-
src/client/pull.rs | 2 +-
src/tools/fs.rs | 39 +++++++++++++++++++--
tests/prune.rs | 6 ++--
10 files changed, 110 insertions(+), 127 deletions(-)
--
2.20.1
next reply other threads:[~2020-08-11 8:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 8:50 Stefan Reiter [this message]
2020-08-11 8:50 ` [pbs-devel] [PATCH v2 proxmox-backup 1/7] src/tools/fs.rs: new helper lock_dir_noblock Stefan Reiter
2020-08-11 8:50 ` [pbs-devel] [PATCH v2 proxmox-backup 2/7] src/backup/backup_info.rs: remove BackupGroup lock() Stefan Reiter
2020-08-11 8:50 ` [pbs-devel] [PATCH v2 proxmox-backup 3/7] datastore: prevent in-use deletion with locks instead of heuristic Stefan Reiter
2020-08-11 8:50 ` [pbs-devel] [PATCH v2 proxmox-backup 4/7] backup: flock snapshot on backup start Stefan Reiter
2020-08-11 8:50 ` [pbs-devel] [PATCH v2 proxmox-backup 5/7] Revert "backup: ensure base snapshots are still available after backup" Stefan Reiter
2020-08-11 8:50 ` [pbs-devel] [PATCH v2 proxmox-backup 6/7] backup: lock base snapshot and ensure existance on finish Stefan Reiter
2020-08-11 8:50 ` [pbs-devel] [PATCH v2 proxmox-backup 7/7] prune: also check backup snapshot locks Stefan Reiter
2020-08-11 9:35 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811085042.30686-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox