From: Oguz Bektas <o.bektas@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup] fix #2909: handle missing chunks gracefully in garbage collection
Date: Wed, 5 Aug 2020 12:15:21 +0200 [thread overview]
Message-ID: <20200805101521.GA11449@gaia.proxmox.com> (raw)
In-Reply-To: <1596622203.98gp6kwkr5.astroid@nora.none>
On Wed, Aug 05, 2020 at 12:11:37PM +0200, Fabian Grünbichler wrote:
> On August 5, 2020 6:50 am, Dietmar Maurer wrote:
> > But now the task finish with status Ok?
> >
> > IMHO, this is a serious problem...
> >
>
> for verify this should cause the task to fail, but for GC I am not so
> sure. the garbage collection itself is fine (by definition, any missing
> chunk the GC encounters is one that should not be garbage collected), it
> just found an unrelated problem?
i was thinking the same.
but i'm sending a new version soon
using worker.warn instead of worker.log should make it continue with a
warning status.
>
> >> On 08/04/2020 4:01 PM Oguz Bektas <o.bektas@proxmox.com> wrote:
> >>
> >>
> >> instead of bailing and stopping the entire GC process, log the missing
> >> chunk errors and continue.
> >>
> >> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> >> ---
> >> src/backup/datastore.rs | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
> >> index ffd64b81..063fba53 100644
> >> --- a/src/backup/datastore.rs
> >> +++ b/src/backup/datastore.rs
> >> @@ -436,8 +436,8 @@ impl DataStore {
> >> tools::fail_on_shutdown()?;
> >> let digest = index.index_digest(pos).unwrap();
> >> if let Err(err) = self.chunk_store.touch_chunk(digest) {
> >> - bail!("unable to access chunk {}, required by {:?} - {}",
> >> - proxmox::tools::digest_to_hex(digest), file_name, err);
> >> + worker.log(&format!("warning: unable to access chunk {}, required by {:?} - {}",
> >> + proxmox::tools::digest_to_hex(digest), file_name, err));
> >> }
> >> }
> >> Ok(())
> >> --
> >> 2.20.1
> >>
> >>
> >> _______________________________________________
> >> pbs-devel mailing list
> >> pbs-devel@lists.proxmox.com
> >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> >
> >
> > _______________________________________________
> > pbs-devel mailing list
> > pbs-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> >
> >
> >
prev parent reply other threads:[~2020-08-05 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 14:01 Oguz Bektas
2020-08-05 4:50 ` Dietmar Maurer
2020-08-05 10:11 ` Fabian Grünbichler
2020-08-05 10:15 ` Oguz Bektas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805101521.GA11449@gaia.proxmox.com \
--to=o.bektas@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox